Shell::Option demolition - #921
Open
MichaelRawson wants to merge 9 commits into
Open
Conversation
Contributor
Author
|
At least on my compiler this hacking seems to have allowed a reasonable release compile time for |
MichaelRawson
force-pushed
the
michael-options
branch
4 times, most recently
from
September 8, 2026 08:22
a783540 to
e30c145
Compare
MichaelRawson
force-pushed
the
michael-options
branch
from
September 11, 2026 14:54
e30c145 to
3ea05ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell::Optionshad grown over a decade or so and become quite convoluted. Straighten it out a bit:Options.cppso it doesn't bother every other translation unit.#includes in the header.const char *rather thanstd::stringfor option names (since they are all statically known), and various other de-heapifications.OptionValueConstraint<T>system - you can still write exactly the same expressions, but without the evilAbstractOptionValueConstraint/WrappedConstraintheadache.Options::init()is now justOptions()OptionValue<T>no longer has a scary default constructor that does...something. This was only necessary because options were not initialised inOptions().I'm not sure what the best way to review this is, as it amounts to a rewrite. Maybe I'll just grab @quickbeam123 at some point and inform him of its various virtues.