feat: incorporate modern-delivery ideas, judgment-scaled (ADR 0023; counter to #22)#24
feat: incorporate modern-delivery ideas, judgment-scaled (ADR 0023; counter to #22)#24vpciii wants to merge 1 commit into
Conversation
…ounter to #22) The methodology-consistent answer to PR #22's six-practice expansion (BLOCKed by adversarial review, docs/reviews/pr22). Adds exactly the one idea with no existing home, and folds the rest where they belong: - §12 Deterministic onboarding — one documented, reproducible setup command; "works on my machine" is a defect; tool is a per-project choice, not a mandate. Tool-agnostic, judgment-scaled. - "Automate what is checkable" sharpened — formatting/style enforced; if a machine settles it, review attends to behavior not style (folds in #22's automated-gates + code-review nuggets without a new practice). - Adds nothing else: refactoring (ADR 0014), docs-as-code (ADR 0020), review (ADR 0015), and CD (per-project, §4+§11) are already covered — re-adding would violate ADR 0022. Self-consistent in the same PR (the thing #22 missed): §1–§11 → §1–§12, README count, and the global-CLAUDE.md / methodology.mdc summaries synced (ADR 0018). Cuts 0.12.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Claude finished @vpciii's task in 3m 30s —— View job Review: ADR 0023 — judgment-scaled delivery ideas (counter to #22)
I reviewed this against the methodology's own standards (ADR 0022 single-source, ADR 0018 summaries-in-same-PR, ADR 0005 navigability, the standing exclusions). The judgment call at the core is sound: §12 is the one genuinely-new, tool-agnostic gap (developer entry path, distinct from §6 config and §10 reproducible builds), and folding the review-attention nugget into "Automate what is checkable" rather than minting new practices is exactly the ADR 0022 discipline. The self-consistency work is real and verified — see below. One blocking defect, one optional note. 🔴 Dangling reference —
|
|
Withdrawing. A round-9 adversarial review (docs/reviews/pr24_adversarial_review.md) BLOCKed this counter-proposal, and most of it holds: the 'automate what is checkable' refinement creates a second home for ADR 0015; §12 largely overlaps §6/§10 (a stricter standard than I applied to #22); CD was treated asymmetrically; and the ADR-number collision is real. (One finding — 'stale §11 references' — was a false positive: §12 was appended, not renumbered, so §11 references to the Reversibility practice remain valid.) Conceded. Resolution: status quo — neither #22 nor #24 lands. |
Round 9: Gemini BLOCKed Claude's counter-proposal (PR #24) — and most of it held (the refinement duplicates ADR 0015; §12 overlaps §6/§10; asymmetric CD treatment; ADR-number collision). Claude conceded those and refuted one finding as a false positive (the "stale §11 refs" claim — §12 was appended, not renumbered). That false positive is the trial's first, and useful calibration: a verifiable factual overreach, refutable by grep. Both PR #22 (Gemini's expansion) and PR #24 (Claude's counter) are now withdrawn — the methodology resisted expansion in both directions. Records the adjudication (pr24_adjudication.md) and the new named failure mode (adversary-authored-replacement bias). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A PR #25 review (the same-model GitHub reviewer) correctly flagged that the v0.12.0 §10 onboarding bullet is a normative practice extension that shipped without an ADR — against the methodology's own "practice changes get an ADR" rule, and unlike comparable additions (ADR 0014, 0016). ADR 0003 (which defines §10's bullets) is append-only, so ADR 0023 records the new bullet and makes §10 traceable again. Also trims the 0.12.0 changelog entry's process-journal backstory (the #22/#24 narrative), keeping the substance + adoption line and citing ADR 0023. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Summary
The methodology-consistent alternative to PR #22. Accept one or the other, not both — if you take this, close #22.
PR #22 proposed six new mandated practices and was BLOCKed by adversarial review (
docs/reviews/pr22_adversarial_review.md) for duplicating existing practices/ADRs, contradicting standing exclusions, and inverting scale-to-work. This captures what's genuinely worth keeping, the methodology's way.What it does
Self-consistency (what #22 missed)
Updated in this same PR:
§1–§11→§1–§12, the README practice count, and theglobal-CLAUDE.md/methodology.mdcsummaries (ADR 0018). Cuts 0.12.0.Provenance
This whole exchange — Gemini authors an over-reaching expansion → Claude adversary BLOCKs it → Claude drafts the judgment-scaled counter — is the cross-model review practice (trial round 8) doing exactly what it's for. Fair game to run the adversary on this PR too.
🤖 Generated with Claude Code