Skip to content

Conversation

@smortex
Copy link
Member

@smortex smortex commented Jan 27, 2026

Reverts #733 following discussions in #733 (comment)

@tj-cisco
Copy link
Contributor

Why revert this? It works and doesn't break anything, having graceful input handling is a good improvement!

@smortex
Copy link
Member Author

smortex commented Jan 27, 2026

Why revert this?

Consistency and correctness? "1.0.0" and 1 and accepted, but 1.0 is not. This is inconsistent. We can add a Float so that 1.0 is accepted too, but then there is one more "incorrect" ways to pass a version number because a version number is indeed a String.

Hence the request to revert this and only accept a version number as a String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants