Skip to content

fix(command): resolve fspy program before spawn#1978

Closed
wyf027 wants to merge 1 commit into
voidzero-dev:mainfrom
wyf027:codex/fspy-resolve-program
Closed

fix(command): resolve fspy program before spawn#1978
wyf027 wants to merge 1 commit into
voidzero-dev:mainfrom
wyf027:codex/fspy-resolve-program

Conversation

@wyf027

@wyf027 wyf027 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Resolve run_command_with_fspy binaries through the same resolve_program path used by run_command.
  • Preserve Windows .cmd to PowerShell prefix args before user args when fspy is enabled.
  • Update the missing-binary test expectation to match the shared resolver error.

Why

run_command_with_fspy passed the bare binary name directly to fspy::Command::new, so PATH resolution happened inside fspy instead of using Vite+'s resolver. On Windows this can make fspy pick up environment-sensitive shim paths differently from run_command. Reusing resolve_program keeps both command paths aligned and follows the fix direction described in #1599.

Fixes #1599.

Validation

  • rustfmt --edition 2024 crates/vite_command/src/lib.rs
  • git diff --check
  • Confirmed fspy::Command::new<P: AsRef<OsStr>> in voidzero-dev/vite-task at the locked fspy rev accepts the resolved path argument.

Cargo tests could not run in this local checkout because the workspace references rolldown/crates/rolldown_binding/Cargo.toml, but the rolldown/ directory is not present here.

@netlify

netlify Bot commented Jun 28, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 25106bf
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a414a99552b280008f70a76

@wyf027

wyf027 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Closing this draft PR to avoid duplicating prior unmerged work and adding extra review noise.

@wyf027 wyf027 closed this Jun 28, 2026
@wyf027 wyf027 deleted the codex/fspy-resolve-program branch June 28, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: cargo test -p vite_command fspy tests fail when node resolves to Vite+ shim

1 participant