fix(command): resolve fspy program before spawn#1978
Closed
wyf027 wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Author
|
Closing this draft PR to avoid duplicating prior unmerged work and adding extra review noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_command_with_fspybinaries through the sameresolve_programpath used byrun_command..cmdto PowerShell prefix args before user args when fspy is enabled.Why
run_command_with_fspypassed the bare binary name directly tofspy::Command::new, so PATH resolution happened inside fspy instead of using Vite+'s resolver. On Windows this can make fspy pick up environment-sensitive shim paths differently fromrun_command. Reusingresolve_programkeeps both command paths aligned and follows the fix direction described in #1599.Fixes #1599.
Validation
rustfmt --edition 2024 crates/vite_command/src/lib.rsgit diff --checkfspy::Command::new<P: AsRef<OsStr>>invoidzero-dev/vite-taskat the locked fspy rev accepts the resolved path argument.Cargo tests could not run in this local checkout because the workspace references
rolldown/crates/rolldown_binding/Cargo.toml, but therolldown/directory is not present here.