fix(env): keep env print session-scoped#1974
Closed
liangmiQwQ wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
This seems only to |
Collaborator
Author
|
I found its root cost is the prepend node logic, and I launch my terminal with Node.js so some PATH is injected by mistake. But I think this is still a bug need fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
vp env printprepends the resolved Node runtime bin directory toPATH. That makesnpm install -gbelieve Node-version-specific global bins are stable, so Vite+ skips creating links in~/.vite-plus/bineven though those bins disappear when the user changes projects or Node versions.This PR changes
vp env printto print a sessionVP_NODE_VERSIONassignment instead. The shims still resolve the requested Node version, while~/.vite-plus/binremains the stable PATH surface.🤖 Generated with Codex