fix(env): report npm-linked globals in which#1968
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91b67aefbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a1fa391c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
left a comment
fengmk2
left a comment
There was a problem hiding this comment.
@liangmiQwQ Love this "feature" 😄
|
|
@wan9chi will follow up on it. |
2 participants
The current
vp env whichonly checks Vite+-managed global package metadata for non-core tools. That means binaries linked after an interceptednpm install -g, such astsc, can run from~/.vite-plus/binbut still report as not found.This PR makes
vp env whichuseBinConfigas the binary ownership source. Vite+-managed bins still resolve through package metadata, while npm-created links report the linked path and available package/node metadata.🤖 Generated with Codex