Renovate: point bundle-dep note at the auto-rebuild workflow#48
Merged
Conversation
The needs-bundle-rebuild label already triggers rebuild-bundle.yml (added in #47), which re-runs pnpm build:action and pushes the refreshed dist. The prBodyNote still told maintainers to do that by hand, so following it caused duplicate/racing pushes (non-fast-forward rejects). Rewrite the note and the rule's description to state the rebuild is automatic, with a fork-PR fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
needs-bundle-rebuildlabel already triggersrebuild-bundle.yml(added in #47), which re-runspnpm build:actionand pushes the refreshed dist. TheprBodyNotestill instructed maintainers to do that by hand, so following it caused duplicate/racing pushes (non-fast-forward rejects) once the bot had already pushed.Rewrite the note and the rule's internal description to state the rebuild happens automatically via the label, with a fork-PR fallback (the bot can't push to fork branches).
Config-only, no behavior change to the automation itself. Surfaced by a code review of the recent Renovate/bundle-rebuild changes.