This repository was archived by the owner on Mar 6, 2024. It is now read-only.
get_logger uses root directory file#784
Open
EarthmanT wants to merge 1 commit intovmware-archive:masterfrom
Open
get_logger uses root directory file#784EarthmanT wants to merge 1 commit intovmware-archive:masterfrom
EarthmanT wants to merge 1 commit intovmware-archive:masterfrom
Conversation
No automation system should have write access to this file. https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
|
@EarthmanT, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@EarthmanT, VMware has approved your signed contributor license agreement. |
rocknes
approved these changes
Dec 21, 2021
Contributor
rocknes
left a comment
rocknes
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EarthmanT)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No automation system should have write access to this file.
https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
To help us process your pull request efficiently, please include:
(Required) Short description of changes in the PR topic line
(Required) Detailed description of changes include tests and
documentation. If the pull request contains multiple commits with
detailed messages, refer to those instead
(Optional) Names of reviewers using @ sign + name
This change is