This repository was archived by the owner on Mar 6, 2024. It is now read-only.
add "if" conditional to avoid looping with a non-existent attribute#737
Open
Trenthani wants to merge 3 commits intovmware-archive:masterfrom
Open
add "if" conditional to avoid looping with a non-existent attribute#737Trenthani wants to merge 3 commits intovmware-archive:masterfrom
Trenthani wants to merge 3 commits intovmware-archive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help us process your pull request efficiently, please include:
Added in a hasattr check for the list_virtual_hardware_section. Current behaviour, when running the function with a VM without any disk's an AttributeError is returned. This changes avoids the error and in turn returns no results.
Testing:
code snip
Before the change on a vm with no disk, AttributeError was returned.
After, no excetions were raised and the correct info returned.
This change is