[Misc] Fix tpu platform init failure when vllm_config is not fully initialized #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
sixiang-google
force-pushed
the
sixiang/fix-oncall
branch
from
dd11482 to
7ebfc28
Compare
QiliangCui
requested changes
Dec 19, 2025
Merged
QiliangCui
added a commit
that referenced
this pull request
Dec 19, 2025
Signed-off-by: Qiliang Cui <[email protected]> All the test failures are ``` E AttributeError: 'NoneType' object has no attribute 'max_model_len' ``` #1335 is fixing it.
QiliangCui
added a commit
that referenced
this pull request
Dec 19, 2025
Signed-off-by: Qiliang Cui <[email protected]> all test failures are ``` E AttributeError: 'NoneType' object has no attribute 'max_model_len' ``` #1335 is fixing it.
sixiang-google
added
the
ready
QiliangCui
approved these changes
Dec 19, 2025
CienetStingLin
pushed a commit
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caused by https://github.com/vllm-project/vllm/pull/30531/files#diff-6b7df8c9b2e791e958973a94a2027ffa4e6acafc3fbcb275d48b6e22e34fc94eR16-R19
If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure: