Make JSON1 with presence available to frontend and backend#51
Closed
Make JSON1 with presence available to frontend and backend#51
Conversation
Contributor
Author
|
Reached a juncture here:
Considering the endgame scenarios as context:
Therefore I'm leaning towards option A. |
Contributor
Author
|
Tried option A to no avail. The server side works, but the client side has issues with the build. Even after adding the CommonJS Vite plugin (which I really would rather not do), the build fails as It occurred to me that the best way forward might be to isolate all the legacy build madness and add JSON1 with presence to https://github.com/vizhub-core/sharedb-client-browser . That way, nothing needs to change about our code here except to import another asset from that package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
srcfrom Presence updated ottypes/json1#47