Conversation
orderly_web/__about__.py
Outdated
| @@ -0,0 +1,2 @@ | |||
| __version__ = "1.1.0" | |||
| __name__ = "pyorderly" | |||
There was a problem hiding this comment.
indeed that is really quite wrong
.github/workflows/ci.yml
Outdated
| - uses: actions/checkout@v3 | ||
| - name: Set up Python ${{ matrix.config.py }} | ||
| uses: actions/setup-python@v4 |
There was a problem hiding this comment.
These two actions (checkout, setup-python) have later versions available but perhaps those are not relevant
.github/workflows/ci.yml
Outdated
| # This can be useful, but the false positive rate is | ||
| # annoyingly high. | ||
| fail_ci_if_error: false |
There was a problem hiding this comment.
Makes me go :/ - I'd rather people consciously choose to merge a PR that has red crosses on, than not notice the red crosses.
There was a problem hiding this comment.
The error is on upload of the coverage report, failure running the coverage will still fail the build
There was a problem hiding this comment.
Right, this is absolutely broken atm, I've removed this step for now as this package is essentially deprecated anyway
This is due to a change in constellation 1.2.3 - see vimc/orderly-web-deploy#56 for an analogous fix
Co-authored-by: David Mears <[email protected]>
|
I might have approved too hastily because trying to run this locally I got
and
here's the full output: https://pastebin.com/MTTkX11K I had run these: hatch shell
orderly-web start config/basicPlausibly to do with me not being added to the right docker team or something. |
|
You probably just need to add |
|
Good point
(I have to again switch the ports away from the defaults, and add the port to the configured |
This is due to a change in constellation 1.2.3 - see vimc/orderly-web-deploy#56 for an analogous fix
2 participants
Before touching the constellation, this updates this package to (minimally) use hatch. I've not set up anything like the linting tools etc because we won't use it much longer.
The commit 09349df cherry-picks (modulo a small merge issue) the change from #53, made by @david-mears-2
The other big change is explicitly pulling all used images; this is due to this change in constellation: https://github.com/reside-ic/constellation/pull/22/files - alternatively we could have passed
pull_images = Trueto every call to.start().Closes #53, but contains the core commit