docs: fix drift in Backup & Recovery - #313
Draft
jack-arturo wants to merge 1 commit into
Draft
Conversation
- --cleanup --keep N is a file count per store, not an age in days - FALKORDB_PORT/FALKORDB_PASSWORD are not required; document AUTOMEM_BACKUP_DIR - FalkorDB export is a Cypher node/relationship dump, not a Redis keyspace dump - Qdrant backup is an object with a points array, not a bare array - fix the jq integrity check that assumed a top-level array Verified against verygoodplugins/automem@42ba8b6 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tnorev9PMn8gL7uTyZzege
Deploying automem-website with
|
| Latest commit: |
a214484
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d5a7bf70.automem-website.pages.dev |
| Branch Preview URL: | https://docs-audit-operations-backup-nd44.automem-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine docs-accuracy audit. First review of this page — no prior review state existed for
operations/backup.--cleanup --keep 7"deletes backups older than 7 days"--keepis a count of files, not an age.cleanup_old_backup_files()sorts each store's*.json.gzby mtime and unlinks everything past indexkeep--cleanup --keep Nflag removes backups older than N days based on filename timestamp parsing"p.stat().st_mtime; the filename timestamp is never parsed for retentionFALKORDB_PORTandFALKORDB_PASSWORDas Required: Yes (while also givingFALKORDB_PORTa default)os.getenvreads with no requirement check — port defaults to6379, password defaults toNone.AUTOMEM_BACKUP_DIRis read by the script but absent from the tableAUTOMEM_BACKUP_DIRrow addedexport_falkordb_artifact()runs pagedMATCH (n)/MATCH (a)-[r]->(b)Cypher queries and gzips a JSON object{timestamp, graph_name, nodes, relationships, stats}. No Redis keys and no index definitions are capturedzcat … | jq 'length'export_qdrant_artifact()writes an object{timestamp, collection_name, points, stats}.jq 'length'on that returns 4 (the key count), not the memory countpointsarray; thejqexample now reads.stats.points_countand.points | lengthVerified against: verygoodplugins/automem@42ba8b6
Checked and found accurate, left unchanged: every
backup_automem.pyandrestore_from_backup.pyflag shown on the page (--backup-dir,--s3-bucket,--cleanup,--keep,--backup-timestamp,--qdrant-only); thefalkordb_<ts>.json.gz/qdrant_<ts>.json.gznaming andbackups/<store>/layout; the S3 key prefixautomem-backups/<store>/<file>;health_monitor.py --auto-recoverbeing a CLI flag with no env-var equivalent;recover_from_qdrant.py'srestore_memory_to_graph_only()and the exactRESERVED_FIELDSset;scripts/cleanup_memory_types.py; the backup workflow's 6-hour cron and its full secret list.Questions
my-automem-backups, butbackup.ymlruns--s3-bucket automem-backups. Read as a placeholder it is fine, read as a diagram of that workflow it is wrong. Not changed — the bucket is user-chosen and the rest of the page uses the same placeholder consistently.--cleanup --keep 14, which the page never states. The Layer 3 diagram says "Last 7-14 backups", which is compatible but vague. Left alone rather than guessing at intent.Unverified
None — every code-anchored claim on this page resolved to current source.
Follow-ups
json.load()", the same array-vs-object error fixed in prose above. Left to keep this PR at the 5-fix cap.automem@57264a9; they still resolve, and no link on the page was touched by this PR.Generated by Claude Code