Fix RELEASES downloading from private repo#103
Fix RELEASES downloading from private repo#103anthrax63 wants to merge 2 commits intovercel:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/hazel/HXK18qcoW6NSF9yBzNbwdjnfAUj3 |
|
Also i added ability to download any file from latest release. It is needed for Squirrel Windows to download nupkg file via proxy. |
|
@anthrax63 nice work! I needed these changes in order to have a functioning auto updater for our Windows build. These changes should be merged to master! |
|
Any updates? |
| content = content.replace( | ||
| matches[0], | ||
| `${this.config.url}/download/nupkg?update=true` | ||
| `${this.config.url}/download/latest/${matches[0]}` |
There was a problem hiding this comment.
change
${this.config.url}/download/latest/${matches[0]}
to
https://${this.config.url}/download/latest/${matches[0]}
To avoid/fix Squirrel 4294967295 error: System.Exception: Filename can either be an absolute HTTP[s] URL, or a file name
There was a problem hiding this comment.
Can confirm that PR works. Any plans on merging it to master?
5 participants
In the previous version, the RELEASES file was downloaded using the browser download url, which gives 404 for private repositories.