Repository navigation
feat(flags-core): add opt-in client state debug logging - #518
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luismeyer
added this pull request to stack #512
September 23, 2026 13:34
luismeyer
force-pushed
the
codex/flags-client-debug
branch
from
September 30, 2026 14:56
09a8e94 to
f50ca9f
Compare
luismeyer
force-pushed
the
codex/flags-client-debug
branch
from
October 1, 2026 10:30
f50ca9f to
0768d43
Compare
luismeyer
force-pushed
the
codex/flags-client-debug
branch
from
October 1, 2026 11:00
76e3975 to
7abefe2
Compare
luismeyer
force-pushed
the
codex/flags-client-debug
branch
from
October 1, 2026 11:49
7abefe2 to
4925dc8
Compare
Contributor
|
You must have Developer access to commit code to Vercel Examples on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
vincent-derks
approved these changes
Oct 5, 2026
…ests Parse DEBUG like the debug package (comma/space separated patterns, wildcards, and - exclusions), cache the parse by raw value so disabled calls stay cheap, and share the switch between client diagnostics and the ingest debug header. Distinguish the fetch deadline from external cancellation in datafile.fetch.aborted. Cover the redaction and throwing-console guarantees through the public API. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WjWjQyvVvunuerU51GvB9M
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #511 (
codex/flags-header-source), including the unified polling initialization and source-assessment fixes.Set
DEBUG=@vercel/flags-coreto follow the controller, shared cache, and network sources through one globalconsole.debuglogger. Every event includes the configuredclientNameso concurrent clients can be distinguished.State transitions show the previous state, next state, and reason. Evaluation and
getDatafile()events show project, revision, age, freshness assessment, and failure allowance. Refresh events distinguish background, blocking, and shared work; response receipt is separate from cache application. Stream-confirmed cancellation is distinguished from shutdown, and ordinary freshness confirmations do not look like outage recovery. Startup events expose timeout and freshness thresholds. HTTP retries and stream reconnects include attempt counts, delays, and reasons.Source assessment failures log
cache.source-errorandheader.fallbackwith reasonsource-assessment-error. Failed cold fetches propagate normally without claiming a source switch. Every polling transition logsstart-pollingand goes through polling initialization, including real stream disconnects.Logging remains off by default, checks the namespace on each call, and computes details lazily. Diagnostics omit credentials, raw headers, definitions, evaluation entities, and raw error messages; a throwing console cannot interrupt client operations. The README includes an example trace and event guide. Event names and fields are internal diagnostics.
Validation: the rebased tree exactly matches the reviewed local implementation. All 1,012 core unit tests pass on Node 22 and Node 24; TypeScript, the core build, changed-file Biome, and diff checks pass. Regression coverage includes shared polling startup, stale-if-error at timeout, recovery from the stream while HTTP is pending, and shutdown cancellation without an unhandled rejection. Live-service integration tests were excluded.