Skip to content

fix(slack): collect thread files since the last mention and skip remote files - #4637

Open
AndrewBarba wants to merge 3 commits into
mainfrom
barba/attachments-slack
Open

AndrewBarba wants to merge 3 commits into
mainfrom
barba/attachments-slack

Conversation

@AndrewBarba

@AndrewBarba AndrewBarba commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Slack's thread lookback stopped at the first message the app didn't post. So a file shared before a follow-up question never reached the agent (#705). A Google Drive or Dropbox file shared through Slack's integration has a third-party URL the bot token can't open (#855).

When an app mention carries no files, eve now collects files in thread order from the messages between the previous mention of the app and the trigger, up to 10 messages back. It skips the app's own messages and duplicate file ids. When the cached first page of replies doesn't reach the trigger, eve pages forward to it, up to 1,000 replies, and keeps the last 11 messages. The earlier mention's turn already collected the files before it, so nothing is sent twice. DMs and threads where the app answers without a mention get no lookback. Remote files (mode: "external") are skipped on every inbound path, and their link stays in the message text. Audio and video are no longer dropped, and file downloads time out after 30 seconds.

Closes #705 and #855. Stacked on #4636.

Validation

  • New attachments.test.ts and inbound.test.ts cases cover:
    • the lookback boundary and its 10-message window
    • a duplicate file id and a reply after the trigger
    • a labelled mention
    • external files on the event and webhook paths (the webhook case fails without its filter)
    • no lookback without a mention
    • a trigger past the cached first page, and paging to it
  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts: 9450 passed, 1 skipped.
  • pnpm --filter eve exec vitest run --config vitest.integration.config.ts src/public/channels/slack: passed.
  • pnpm --filter eve run typecheck, pnpm fmt, pnpm guard:invariants, and pnpm docs:check pass.

Checklist

  • I added tests and documentation where relevant
  • I added a changeset if this touches the published eve package
  • DCO sign-off passes for every commit (git commit --signoff)

@AndrewBarba
AndrewBarba requested a review from a team as a code owner October 10, 2026 17:15
@AndrewBarba
AndrewBarba added this pull request to stack #4638 October 10, 2026 17:15
@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
eve-docs Ready Ready Preview, v0 Oct 10, 2026 11:41pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
eve-pkg Skipped Skipped v0 Oct 10, 2026 11:41pm UTC

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • No notable deltas vs main (b6b353f).

Delta vs main (b6b353f)

Area Metric Baseline Current Delta
Package Packed tarball 7.58 MB 7.58 MB +1.3 kB ⚠️
Package Unpacked publish size 26.70 MB 26.71 MB +3.8 kB ⚠️
Package Installed footprint 74.50 MB 74.51 MB +3.8 kB ⚠️
Package Published files 4117 4117 0
Package Installed files 8122 8122 0
Package Installed package instances 34 34 0
Package Distinct installed package names 32 32 0
Package Installed dependency edges 51 51 0
Package Installed optional peer edges 9 9 0
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 20.39 MB 20.39 MB -120 B ✅
Runtime Public routes 18 18 0
Changed function payloads vs main (b6b353f) (2)
Function Status Baseline Current Delta Route changes
functions/__server.func changed 10.20 MB 10.20 MB -60 B ✅ none
functions/.well-known/workflow/v1/flow.func changed 10.20 MB 10.20 MB -60 B ✅ none

eve init install

Metric Baseline Current Delta
Installed footprint 112.80 MB 112.80 MB +3.8 kB ⚠️
Installed packages 97 97 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 44.79 MB 44.79 MB +3.8 kB ⚠️
devDependency package bytes 5.11 MB 5.11 MB 0 B ➖
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260903-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-10-10T23:41:43.149Z
  • Route aliases: 18 public, 1 internal (19 total aliases)
  • Vercel routes in config: 21
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.76.3
  • Package directory: packages/eve
  • Tarball: 7.58 MB (eve-0.76.3.tgz)
  • Unpacked payload: 26.71 MB across 4117 published files
  • Installed footprint: 74.51 MB across 8122 installed files
  • Installed root package: 26.71 MB
  • Installed dependencies: 47.80 MB
  • Installed package instances: 34
  • Distinct installed package names: 32
  • Installed dependency edges: 51
  • Installed optional peer edges: 9
  • Runtime dependencies: 2
  • Peer dependencies: 7 (6 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.
Graph metrics read only package.json files in package directories directly beneath a node_modules boundary, including nested boundaries. Each directory is one package instance; distinct names come from those manifests. Dependency edges count each unique name in dependencies or optionalDependencies per instance; optional peer edges count peerDependencies marked optional.

Heavy installed dependencies

  • eve: 26.71 MB (35.8%)
  • @rolldown/binding-linux-x64-gnu: 19.62 MB (26.3%)
  • ai: 8.14 MB (10.9%)
  • zod: 6.14 MB (8.2%)
  • undici: 3.56 MB (4.8%)
Publish payload breakdown
Published file size
🟠 dist/src/compiled/shadcn-registry/index.js       [#####...................] 3.85 MB 14.4%
🟠 dist/src/compiled/@photon-ai/chat-adapter-ime... [###.....................] 2.29 MB 8.6%
🟠 dist/src/compiled/@ai-sdk/code-mode/index.js     [#.......................] 1.03 MB 3.8%
🟡 dist/src/compiled/@vercel/blob/index.js          [#.......................] 604.9 kB 2.3%
🟡 dist/src/compiled/_chunks/workflow/undici-D-I... [#.......................] 521.9 kB 2.0%
🔴 Other published files                            [########################] 18.42 MB 69.0%
Installed footprint breakdown
Installed package size
🔴 eve                             [########################] 26.71 MB 35.8%
🔴 @rolldown/binding-linux-x64-gnu [##################......] 19.62 MB 26.3%
🔴 ai                              [#######.................] 8.14 MB 10.9%
🔴 zod                             [######..................] 6.14 MB 8.2%
🟠 undici                          [###.....................] 3.56 MB 4.8%
🟠 nitro                           [##......................] 1.89 MB 2.5%
🔴 Other installed packages        [########................] 8.44 MB 11.3%
Runtime dependencies (2)
Package Range Notes
nitro 3.0.260903-beta
undici 8.10.2
Peer dependencies (7)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
chat ^4.41.0 optional peer
dd-trace ^6.13.0 optional peer
just-bash ^3.1.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 112.80 MB across 10017 installed files
  • Installed packages: 97 total (91 transitive-only)
  • dependencies: 4 direct packages totaling 44.79 MB
  • devDependencies: 2 direct packages totaling 5.11 MB
  • Other transitive package files: 62.90 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • @typescript/typescript-linux-x64: 27.95 MB (24.8%)
  • eve: 26.71 MB (23.7%)
  • @rolldown/binding-linux-x64-gnu: 19.62 MB (17.4%)
  • zod: 9.76 MB (8.6%)
  • ai: 8.14 MB (7.2%)
Installed footprint breakdown
Installed package size
🔴 @typescript/typescript-linux-x64 [########################] 27.95 MB 24.8%
🔴 eve                              [#######################.] 26.71 MB 23.7%
🔴 @rolldown/binding-linux-x64-gnu  [#################.......] 19.62 MB 17.4%
🔴 zod                              [########................] 9.76 MB 8.6%
🔴 ai                               [#######.................] 8.14 MB 7.2%
🟠 undici                           [###.....................] 3.56 MB 3.2%
🔴 Other installed packages         [###############.........] 17.07 MB 15.1%
dependencies (4)
Package Range Installed size Share
@vercel/connect 2.2.0 188.7 kB 0.2%
ai ^7.0.128 8.14 MB 7.2%
eve file:eve-0.76.3.tgz 26.71 MB 23.7%
zod 4.5.4 9.76 MB 8.6%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.61 MB 2.3%
typescript 7.0.2 2.50 MB 2.2%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 10.20 MB 50.0%
🔴 functions/__server.func                         [########################] 10.20 MB 50.0%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 10.20 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 10.20 MB
Function files 10.20 MB across 118 files
Traced dependencies 0 B
Signal 🟠 Bundled file _chunks/vercel.web.mjs is 2.25 MB (22.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 _chunks/vercel.web.mjs                         [############............] 2.25 MB 22.1%
🟠 _libs/undici.mjs                               [#####...................] 1.01 MB 9.9%
🟡 _chunks/sandbox3.mjs                           [####....................] 815.4 kB 8.0%
🟡 _chunks/compiled-artifacts-instrumentation.mjs [####....................] 757.3 kB 7.4%
🟡 _chunks/token-util-Bla5Z0G9.mjs                [####....................] 704.7 kB 6.9%
🔴 Other bundled files                            [########################] 4.66 MB 45.7%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ],
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1"
  }
}

🟠 functions/__server.func • 17 public routes, 1 internal alias • 10.20 MB
Metric Value
Public routes /
/.well-known/workflow/v1/webhook/[token]
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[attemptId]/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[parentSessionId]/subagents/[callId]/[childSessionId]/stream
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/clear
/eve/v1/session/[sessionId]/compact
/eve/v1/session/[sessionId]/reset
/eve/v1/session/[sessionId]/stream
/eve/v1/session/[sessionId]/stubs
/eve/v1/task-input/[token]
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 10.20 MB
Function files 10.20 MB across 118 files
Traced dependencies 0 B
Signal 🟠 Bundled file _chunks/vercel.web.mjs is 2.25 MB (22.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 _chunks/vercel.web.mjs                         [############............] 2.25 MB 22.1%
🟠 _libs/undici.mjs                               [#####...................] 1.01 MB 9.9%
🟡 _chunks/sandbox3.mjs                           [####....................] 815.4 kB 8.0%
🟡 _chunks/compiled-artifacts-instrumentation.mjs [####....................] 757.3 kB 7.4%
🟡 _chunks/token-util-Bla5Z0G9.mjs                [####....................] 704.7 kB 6.9%
🔴 Other bundled files                            [########################] 4.66 MB 45.7%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 3.62 s -> 3.59 s (-29.7 ms) vs main (b6b353f).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `main (b6b353f)`
Phase Baseline Current Delta
extension.check 16.5 ms 17.4 ms +0.9 ms
project.resolve 0.4 ms 0.4 ms 0.0 ms
workspace.create 0.5 ms 0.5 ms 0.0 ms
host.prepare 794.6 ms 713.7 ms -80.9 ms
vercel.service-prefix.resolve 1.7 ms 2.2 ms +0.5 ms
nitro.create 665.1 ms 667.8 ms +2.7 ms
sandbox.prewarm 199.2 ms 234.8 ms +35.6 ms
nitro.cache.prepare 0.2 ms 0.2 ms 0.0 ms
nitro.prepare 0.7 ms 0.8 ms +0.1 ms
nitro.public-assets 0.8 ms 0.9 ms +0.1 ms
nitro.prerender 0.5 ms 0.5 ms 0.0 ms
nitro.bundle 1.78 s 1.79 s +10.0 ms
nitro.cache.write 0.4 ms 0.5 ms +0.1 ms
vercel.workflow-function.materialize 55.1 ms 55.0 ms -0.1 ms
agent-summary.emit 0.7 ms 0.7 ms 0.0 ms
connect-manifest.emit 0.3 ms 0.4 ms +0.1 ms
nitro.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.7 ms 3.8 ms +0.1 ms
workspace.remove 3.0 ms 2.9 ms -0.1 ms

if (parts.length > 0) return parts;
return [];
const trigger = recent.findIndex((message) => message.ts === input.mention.ts);
if (trigger === -1) return [];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In threads with more than 50 replies, this lookback never runs. refresh() fetches conversations.replies with limit: 50 and no pagination (api.ts:458-469), and Slack returns the oldest page first, so a reply mention after message 50 isn't in recentMessages. We then return [] here. A cache filled earlier by loadThreadContextMessages (thread.ts:49-51) has the same cap, and the length check at line 113 skips the refresh. So "share a file, then ask about it" stops working in exactly the long threads where people tend to do that.

The docs (slack.mdx:747) promise the 10-message lookback without mentioning this limit. Two ways to fix it: fetch the window that ends at the trigger (conversations.replies with latest: mention.ts, inclusive: true, limit: 11) so the lookback doesn't depend on the shared 50-message cache, or document the limit. Either way, a fixture whose history doesn't contain the trigger would cover this path. Right now makeSlackThread always appends the 9.0 trigger, so no test reaches this branch.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. When the cached replies don't include the trigger, the collector fetches the window that ends at it. Slack returns replies oldest first, so latest: mention.ts, limit: 11 alone would give the thread's first 11 messages. Instead it pages forward with latest and inclusive and keeps the last 11, reading at most 5 pages of 200 (1000 replies). Past that the window is unknown, so there's no lookback, and the docs state the bound. The fetch lives in buildSlackBinding and stays off the public SlackThread. New tests cover the paging and a trigger past the cached page.

…te files

Signed-off-by: Andrew Barba <barba@hey.com>
Signed-off-by: Andrew Barba <barba@hey.com>
Signed-off-by: Andrew Barba <barba@hey.com>

This branch was successfully deployed

1 active and 1 inactive deployments
Preview – eve-docs — 1b8ca280 Deployed Oct 10, 2026 by vercel[bot]
Preview – eve-pkg — 1b8ca280 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack channel: images/files posted earlier in a thread are silently dropped — attachment lookback only ever inspects one message

1 participant