Skip to content

Add keyword_tagger link for automatic tagging#132

Closed
howethomas wants to merge 1 commit intomainfrom
feature/keyword-tagger-link
Closed

Add keyword_tagger link for automatic tagging#132
howethomas wants to merge 1 commit intomainfrom
feature/keyword-tagger-link

Conversation

@howethomas
Copy link
Contributor

@howethomas howethomas commented Mar 2, 2026

Note

Medium Risk
Moderate risk because it introduces new automated tagging that mutates stored vCons and may create false positives due to simple substring matching and broad keyword lists.

Overview
Introduces a new server/links/keyword_tagger link that extracts transcription text from vCon analysis entries (supports both transcription and wtf_transcription) and applies tags when predefined or user-supplied keywords are found.

Supports optional config for enabled categories, custom tag-to-keyword mappings, and case sensitivity; when matches occur it persists the updated vCon back to Redis with the added tags.

Written by Cursor Bugbot for commit 59bff4c. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Free Tier Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR


# Other Content
"other": {
"profanity": ["fuck", "shit", "damn", "ass"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substring matching "ass" causes pervasive false profanity tags

High Severity

The profanity keyword list includes "ass", but find_keywords uses plain substring matching (if search_keyword in text). This means any transcription containing common words like "class", "pass", "assistant", "assessment", "assume", "mass", or "classic" will be falsely tagged as containing profanity. Nearly every non-trivial conversation is likely to trigger this false positive.

Additional Locations (1)

Fix in Cursor Fix in Web

"categories": None, # None means all categories
"custom_keywords": {}, # Additional tag -> keywords mappings
"case_sensitive": False,
"min_confidence": 0.0, # Minimum transcription confidence to process
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min_confidence option defined but never checked

Low Severity

The min_confidence option is declared in default_options with a documented comment about minimum transcription confidence, but it is never read or evaluated anywhere in the run function. Users configuring this option would get no effect, and low-confidence transcriptions would still be processed and tagged.

Fix in Cursor Fix in Web

@howethomas howethomas closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant