Skip to content

Improve workflow system for EP further#4891

Merged
Amrsatrio merged 3 commits intovalinet:masterfrom
Kichura:rs_fun_deploy
Mar 13, 2026
Merged

Improve workflow system for EP further#4891
Amrsatrio merged 3 commits intovalinet:masterfrom
Kichura:rs_fun_deploy

Conversation

@Kichura
Copy link
Copy Markdown
Contributor

@Kichura Kichura commented Mar 8, 2026

  1. Drops the unneeded push and pull_request rules as they don't do anything unlike workflow_dispatch's rules,
  2. Sets the contents permission to write in case the workflow becomes read-only by default,
  3. Pins all job versions to their commit hashes to avoid supply chain attacks towards the workflow script,
  4. Moves all environment mentions into the env: section to prevent causing them from getting expanded into attacker-controllable code,
    5. Kills off 32-bit compilation in the workflow system as Windows 11 overall is amd64+arm64 only now, (22000.51 does exist as x86 but is in corpnet only at time of writing)
  5. Freezes the nuget version to 7.x,
  6. Adds the timeout-minutes to the job(s) section so that the CI doesn't take 6 hours straight to get aborted in case something is causing the CI to suddenly stall or become unresponsive, (this can be adjusted if 30 mins is too short or too long)
  7. Sets the if-no-files-found to error by default in case artifacts are absent.

(Security issues were all spotted by zizmor)

@Amrsatrio Amrsatrio merged commit 8be1784 into valinet:master Mar 13, 2026
1 check passed
Amrsatrio pushed a commit to Amrsatrio/ExplorerPatcher that referenced this pull request Mar 13, 2026
* Improve workflow system for EP further.

* Timeout on 30mins, Fix artifact issues.

* Revert IA-32 build removal.

Required by valinet himself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants