settings: match the add-device menu to the sidebar on macOS 26 - #7907
Merged
Merged
Conversation
On macOS 26 and later, the borderless button menu style draws the Devices "New…" entry as a compact pull-down: smaller text, an untinted icon, a chevron, and a text column that does not line up with the other sidebar rows. Only the button menu style combined with the plain button style renders the label like the neighbouring rows, so use that on macOS 26 and keep the existing style on older releases and on iOS. Assisted-by: Claude:claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 26 and later, the Devices "New…" menu in the VM settings sidebar rendered as a compact pull-down (smaller text, untinted icon, chevron, and a text column that does not line up with the other rows) instead of matching the neighbouring sidebar entries. The
.borderlessButtonmenu style is what draws it that way;.menuStyle(.button)combined with.buttonStyle(.plain)renders the label like the other rows, so both the QEMU and Apple add-device menus now use that on macOS 26+. Older macOS releases and iOS keep the existing style.Testing: Tested by a human on macOS 27.0 host + macOS 12.6 VM.
The author acknowledges that this change has been tested and/or reviewed by a human in accordance with UTM's AI contribution guidelines.