fix(messenger-internal): pass base_url through to run() (#60)#66
Merged
Conversation
Companion to the next commit. PR #60's original commit (4c1b7dc) used the non-conventional 'internal:' type prefix that release-please does not recognize, so the fix has been sitting on master unreleased. We can't just push an empty conventional-commit marker because GitHub's merge strategies drop empty commits. Workaround: revert here, re-apply with the right message in the next commit. Net code change on master: zero.
Re-applies the change originally landed in 4c1b7dc (#60) on 2026-05-13 with a conventional-commit subject so release-please picks it up. The previous commit on this branch reverts the change; this one re-applies it. Net code change on master: zero. The diff is identical to 4c1b7dc's diff. Original change: makes baseUrl available so the messenger bundle knows which origin served its loader. Backwards compatible: baseUrl is optional. Existing umm bundles ignore the new field; bundles that read it fall back to their env-baked URL when older messenger-internal omits it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship the baseUrl fix that landed in 4c1b7dc (#60) on 2026-05-13. The original commit used a non-conventional
internal:prefix, so release-please ignored it and the fix has been sitting on master unreleased.We can't push an empty conventional-commit marker (GitHub's merge strategies drop empty commits — see closed PRs #64, #65). Instead, this PR has two non-empty commits with a net code change of zero:
revert(messenger-internal): roll back #60— un-applies the changefix(messenger-internal): pass base_url through to run() (#60)— re-applies the same change with a conventional message release-please understandsAfter rebase-merge, master gets both commits. release-please sees the
fix:and proposes 3.3.1 → 3.3.2 (plus cascade patch on messenger to 2.0.2 via node-workspace).Use "Rebase and merge" — not "Squash and merge". A squash would collapse the two commits and produce the same empty-diff problem as #64.
Test plan