fix(repo): align release-please tag format with existing tags#63
Merged
Conversation
release-please was generating tags as 'messenger@v2.0.1' (component = directory name, v-prefix on version), but the existing repo tags are '@userlike/messenger@2.0.1' (component = full scoped name, no v). The mismatch meant release-please couldn't find any prior tag for either package and fell back to scanning all of git history - it then proposed to 're-release' ancient feat: and BREAKING CHANGE: commits, bumping messenger-internal to 4.0.0 over an old widget_key removal and messenger to 2.1.0 over old feat:s. See closed PR #62. Fix: - component: '@userlike/messenger' (and same for -internal) overrides the directory-name default. - include-v-in-tag: false drops the v-prefix. After this lands, release-please will compute tags as '@userlike/messenger@<version>' which matches the existing tags exactly, find the right starting points, and scan only commits since 2.0.1 / 3.3.1. Since none of those are conventional-commit feat:/fix:/BREAKING, no release PR should open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the wrong-version bumps in the closed PR #62.
release-please was generating tags as
messenger@v2.0.1— directory-name component +vprefix — but the actual repo tags are@userlike/messenger@2.0.1. Since release-please couldn't match either format to find the prior release, it fell back to scanning the entire git history and proposed to "re-release" oldfeat:andBREAKING CHANGE:commits, producing wrong bumps (messenger 2.0.1 → 2.1.0, messenger-internal 3.3.1 → 4.0.0).Changes
"include-v-in-tag": false— drop thevprefix"component": "@userlike/messenger"/"@userlike/messenger-internal"— use the full scoped name as the tag component instead of the directory nameResult: release-please's generated tag becomes
@userlike/messenger@<version>(exactly matching existing tags), so it correctly finds the last release and only scans commits since. Since the recent commits are allchore:/ci:(non-releasing), release-please should sit idle after this lands.Test plan
release-please.ymlrun on master