chore: update protobufjs dependency to version 8.7.1 across monorepo …#405
chore: update protobufjs dependency to version 8.7.1 across monorepo …#405kedar49 wants to merge 1 commit into
Conversation
…packages and examples
|
@HarshaNalluru you can review and merge this PR |
|
There was a problem hiding this comment.
Pull request overview
Updates the JavaScript workspace dependency graph to ensure protobufjs resolves to 8.7.1 (primarily via package manager overrides), addressing security/maintenance concerns raised in #375.
Changes:
- Adds
protobufjs: ^8.7.1overrides in root and affected subprojects (npm + pnpm). - Regenerates lockfiles so
protobufjsresolves to8.7.1and removes now-unneeded@protobufjs/*transitive packages. - Adjusts an
onnxruntime-web-scoped override in the image-search setup project to forceprotobufjs^8.7.1.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds a root-level npm override to prefer protobufjs ^8.7.1. |
apps/next-js/package.json |
Adds an app-level override for protobufjs ^8.7.1. |
apps/next-js/package-lock.json |
Updates locked protobufjs to 8.7.1 and removes @protobufjs/* entries. |
examples/javascript-web/package.json |
Adds an example-level override for protobufjs ^8.7.1. |
examples/javascript-web/package-lock.json |
Updates locked protobufjs to 8.7.1 and removes @protobufjs/* entries. |
packages/vitepress-plugin-moss/package.json |
Adds a pnpm override for protobufjs ^8.7.1. |
packages/vitepress-plugin-moss/pnpm-lock.yaml |
Updates pnpm resolution so protobufjs resolves to 8.7.1 and drops @protobufjs/*. |
moss-live-labs/examples/image-search/setup-js/package.json |
Updates the onnxruntime-web-scoped override to force protobufjs ^8.7.1. |
Files not reviewed (3)
- apps/next-js/package-lock.json: Generated file
- examples/javascript-web/package-lock.json: Generated file
- packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "overrides": { | ||
| "postcss": "^8.5.16" | ||
| "postcss": "^8.5.16", | ||
| "protobufjs": "^8.7.1" | ||
| } |
| "overrides": { | ||
| "protobufjs": "^8.7.1" | ||
| } |
| "onnxruntime-web": { | ||
| "protobufjs": "^7.5.5" | ||
| "protobufjs": "^8.7.1" | ||
| } |
| "minimatch@>=9.0.0 <9.0.7": ">=9.0.7", | ||
| "minimatch@<3.1.3": ">=3.1.3", | ||
| "postcss": "^8.5.13", | ||
| "protobufjs": "^8.7.1", | ||
| "vite": "^6.4.2" |
|
@kedar49 can you fix and update with these changes |
Which changes ? Above is just review of my changes by co-pilot |
Copilot flagged a few duplicate/leftover keys in the overrides blocks that need cleanup before this can merge: |
Check the changes in file again, those are not duplicate entries,one line removed nd one lined added. |
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Upgraded transitive dependency
protobufjsto8.7.1across the workspace to address security vulnerabilities and update packages.Changes
package.json: Addedprotobufjs: ^8.7.1to overrides.apps/next-js/package.json&package-lock.json: Overrode toprotobufjs: ^8.7.1, removing transitive dependencies of@protobufjs/*.examples/javascript-web/package.json&package-lock.json: Overrode toprotobufjs: ^8.7.1, removing transitive dependencies of@protobufjs/*.packages/vitepress-plugin-moss/package.json&pnpm-lock.yaml: Addedprotobufjs: ^8.7.1override.moss-live-labs/examples/image-search/setup-js/package.json: Updated override version foronnxruntime-webto^8.7.1.Testing
Ran the following verification suites successfully:
npm run type-check && npm run lintnpm run build && npm run testpnpm run test && pnpm run buildnpm run type-checknpm run type-check && npm run buildCloses #375
Type of Change