Skip to content

chore: update protobufjs dependency to version 8.7.1 across monorepo …#405

Open
kedar49 wants to merge 1 commit into
usemoss:mainfrom
kedar49:fix/protobufjs-upgrade-375
Open

chore: update protobufjs dependency to version 8.7.1 across monorepo …#405
kedar49 wants to merge 1 commit into
usemoss:mainfrom
kedar49:fix/protobufjs-upgrade-375

Conversation

@kedar49

@kedar49 kedar49 commented Jul 16, 2026

Copy link
Copy Markdown

Pull Request Checklist

Please ensure that your PR meets the following requirements:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation (if applicable).
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Description

Upgraded transitive dependency protobufjs to 8.7.1 across the workspace to address security vulnerabilities and update packages.

Changes

  • Root package.json: Added protobufjs: ^8.7.1 to overrides.
  • apps/next-js/package.json & package-lock.json: Overrode to protobufjs: ^8.7.1, removing transitive dependencies of @protobufjs/*.
  • examples/javascript-web/package.json & package-lock.json: Overrode to protobufjs: ^8.7.1, removing transitive dependencies of @protobufjs/*.
  • packages/vitepress-plugin-moss/package.json & pnpm-lock.yaml: Added protobufjs: ^8.7.1 override.
  • moss-live-labs/examples/image-search/setup-js/package.json: Updated override version for onnxruntime-web to ^8.7.1.

Testing

Ran the following verification suites successfully:

  • Root: npm run type-check && npm run lint
  • Next.js App: npm run build && npm run test
  • VitePress Plugin: pnpm run test && pnpm run build
  • Setup-JS: npm run type-check
  • Javascript-Web: npm run type-check && npm run build

Closes #375

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@CLAassistant

CLAassistant commented Jul 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@kedar49

kedar49 commented Jul 16, 2026

Copy link
Copy Markdown
Author

@HarshaNalluru you can review and merge this PR

@Sravan1011

Copy link
Copy Markdown
Contributor

@HarshaNalluru you can review and merge this PR
@HarshaNalluru you can go ahead with the merge

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JavaScript workspace dependency graph to ensure protobufjs resolves to 8.7.1 (primarily via package manager overrides), addressing security/maintenance concerns raised in #375.

Changes:

  • Adds protobufjs: ^8.7.1 overrides in root and affected subprojects (npm + pnpm).
  • Regenerates lockfiles so protobufjs resolves to 8.7.1 and removes now-unneeded @protobufjs/* transitive packages.
  • Adjusts an onnxruntime-web-scoped override in the image-search setup project to force protobufjs ^8.7.1.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Adds a root-level npm override to prefer protobufjs ^8.7.1.
apps/next-js/package.json Adds an app-level override for protobufjs ^8.7.1.
apps/next-js/package-lock.json Updates locked protobufjs to 8.7.1 and removes @protobufjs/* entries.
examples/javascript-web/package.json Adds an example-level override for protobufjs ^8.7.1.
examples/javascript-web/package-lock.json Updates locked protobufjs to 8.7.1 and removes @protobufjs/* entries.
packages/vitepress-plugin-moss/package.json Adds a pnpm override for protobufjs ^8.7.1.
packages/vitepress-plugin-moss/pnpm-lock.yaml Updates pnpm resolution so protobufjs resolves to 8.7.1 and drops @protobufjs/*.
moss-live-labs/examples/image-search/setup-js/package.json Updates the onnxruntime-web-scoped override to force protobufjs ^8.7.1.
Files not reviewed (3)
  • apps/next-js/package-lock.json: Generated file
  • examples/javascript-web/package-lock.json: Generated file
  • packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/next-js/package.json
Comment on lines 36 to 39
"overrides": {
"postcss": "^8.5.16"
"postcss": "^8.5.16",
"protobufjs": "^8.7.1"
}
Comment on lines +20 to 22
"overrides": {
"protobufjs": "^8.7.1"
}
Comment on lines 46 to 48
"onnxruntime-web": {
"protobufjs": "^7.5.5"
"protobufjs": "^8.7.1"
}
Comment on lines 71 to 75
"minimatch@>=9.0.0 <9.0.7": ">=9.0.7",
"minimatch@<3.1.3": ">=3.1.3",
"postcss": "^8.5.13",
"protobufjs": "^8.7.1",
"vite": "^6.4.2"
@Sravan1011

Copy link
Copy Markdown
Contributor

@kedar49 can you fix and update with these changes

@kedar49

kedar49 commented Jul 19, 2026

Copy link
Copy Markdown
Author

@kedar49 can you fix and update with these changes

Which changes ? Above is just review of my changes by co-pilot

@Sravan1011

Copy link
Copy Markdown
Contributor

@kedar49 can you fix and update with these changes

Which changes ? Above is just review of my changes by co-pilot

Copilot flagged a few duplicate/leftover keys in the overrides blocks that need cleanup before this can merge:
apps/next-js/package.json: "postcss" is listed twice in overrides — duplicate key.
moss-live-labs/examples/image-search/setup-js/package.json: the onnxruntime-web override still has both "protobufjs": "^7.5.5" and "protobufjs": "^8.7.1" — looks like the old line wasn't removed when the new one was added.
packages/vitepress-plugin-moss/package.json: worth double-checking the override block (postcss, protobufjs, minimatch, vite) for the same duplicate-key issue.

@kedar49

kedar49 commented Jul 19, 2026

Copy link
Copy Markdown
Author

@kedar49 can you fix and update with these changes

Which changes ? Above is just review of my changes by co-pilot

Copilot flagged a few duplicate/leftover keys in the overrides blocks that need cleanup before this can merge: apps/next-js/package.json: "postcss" is listed twice in overrides — duplicate key. moss-live-labs/examples/image-search/setup-js/package.json: the onnxruntime-web override still has both "protobufjs": "^7.5.5" and "protobufjs": "^8.7.1" — looks like the old line wasn't removed when the new one was added. packages/vitepress-plugin-moss/package.json: worth double-checking the override block (postcss, protobufjs, minimatch, vite) for the same duplicate-key issue.

Check the changes in file again, those are not duplicate entries,one line removed nd one lined added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update protobufjs to the latest version

4 participants