chore(deps): bump vite to ^8.1.4#398
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s JavaScript/Vite-based subprojects to use vite ^8.1.4 (including overrides) and regenerates the associated lockfiles, plus adds an explicit @vue/language-core devDependency to keep the packages/vitepress-plugin-moss TypeScript declaration build working.
Changes:
- Bump
viteto^8.1.4across relevantpackage.jsonmanifests andpnpm/npmoverrides. - Regenerate
pnpm-lock.yaml/package-lock.jsonfiles for affected workspaces. - Add
@vue/language-coreas an explicit devDependency forvitepress-plugin-mossto stabilize.d.tsgeneration.
Reviewed changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/vitepress-plugin-moss/pnpm-lock.yaml |
Updates resolved dependency graph for vitepress-plugin-moss after Vite 8 bump (plus @vue/language-core resolution). |
packages/vitepress-plugin-moss/package.json |
Bumps Vite dependency/overrides and adds explicit @vue/language-core devDependency. |
packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml |
Updates demo-site lockfile for Vite 8 bump and resulting transitive changes. |
packages/vitepress-plugin-moss/demo-site/package.json |
Updates pnpm override to vite: ^8.1.4. |
packages/moss-md-indexer/pnpm-lock.yaml |
Updates @moss-tools/md-indexer lockfile to reflect Vite 8 override impacts. |
packages/moss-md-indexer/package.json |
Updates vite overrides to ^8.1.4. |
packages/moss-md-indexer/example/package.json |
Updates example overrides to vite: ^8.1.4. |
package.json |
Updates root overrides to vite: ^8.1.4. |
moss-live-labs/examples/image-search/react-app/package.json |
Bumps Vite in the react-app devDependencies to ^8.1.4. |
moss-live-labs/examples/image-search/react-app/package-lock.json |
Regenerated npm lockfile reflecting Vite 8.1.4 and updated transitive deps. |
examples/javascript-web/package.json |
Bumps Vite devDependency to ^8.1.4. |
examples/javascript-web/package-lock.json |
Regenerated npm lockfile reflecting Vite 8.1.4 and updated transitive deps. |
Files not reviewed (6)
- examples/javascript-web/package-lock.json: Generated file
- moss-live-labs/examples/image-search/react-app/package-lock.json: Generated file
- packages/moss-md-indexer/example/pnpm-lock.yaml: Generated file
- packages/moss-md-indexer/pnpm-lock.yaml: Generated file
- packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml: Generated file
- packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "overrides": { | ||
| "esbuild": "^0.28.0", | ||
| "postcss": "^8.5.16", | ||
| "vite": "^6.4.2" | ||
| "vite": "^8.1.4" | ||
| } |
| @@ -49,8 +49,9 @@ | |||
| "@microsoft/api-extractor": "^7.58.7", | |||
| "@types/node": "^20.0.0", | |||
| "@vue/language-core": "^3.2.7", | ||
| "typescript": "^5.0.0", | ||
| "vite": "^6.4.3", | ||
| "vite": "^8.1.4", | ||
| "vite-plugin-dts": "^5.0.0", |
| "devDependencies": { | ||
| "typescript": "^5.7.0", | ||
| "vite": "^8.0.16" | ||
| "vite": "^8.1.4" | ||
| } |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 15 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- examples/javascript-web/package-lock.json: Generated file
- moss-live-labs/examples/image-search/react-app/package-lock.json: Generated file
- packages/moss-md-indexer/example/pnpm-lock.yaml: Generated file
- packages/moss-md-indexer/pnpm-lock.yaml: Generated file
- packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml: Generated file
- packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
packages/vitepress-plugin-moss/package.json:42
- package.json now enforces Node >=20.19.0, but peerDependencies still declare compatibility with vite >=5 and vitepress >=1. That combination is internally inconsistent: consumers running older (but still peer-allowed) vite/vitepress versions on Node 18/20.0 would be blocked by the engines field even if the runtime code would otherwise work.
Either tighten the peerDependency ranges to match the Node floor implied by the tooling (e.g., require vite 8+), or relax/remove the engines constraint if the published package’s runtime still supports older Node versions.
"engines": {
"node": ">=20.19.0"
},
"peerDependencies": {
"vite": ">=5.0.0",
"vitepress": ">=1.0.0"
},
| allowBuilds: | ||
| esbuild: true | ||
| protobufjs: false | ||
| overrides: | ||
| "@vue/language-core": "^3.2.7" |
|
@rohanshrma222 please resolve comments |
on it |
|
Fixed merge conflicts. |
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Bumps
viteto^8.1.4across all manifests (devDependencies and pnpm/npm overrides) and regenerates the corresponding lockfiles: root,examples/javascript-web,moss-live-labs/examples/image-search/react-app,packages/moss-md-indexer(and itsexample/), andpackages/vitepress-plugin-moss(and itsdemo-site/).Also adds
@vue/language-coreas an explicit devDependency inpackages/vitepress-plugin-mossit's an optional peer ofunplugin-dts(viavite-plugin-dts) that was previously pulled into the dependency graph transitively, but stopped being resolved after the vite bump, breakingthe
.d.tsbuild. Declaring it explicitly (pinned to^3.2.7, matching the existingpnpm.overridesentry) fixes it.Verified
vitepress-plugin-mossbuilds and its test suite (45 tests) passes,moss-md-indexerbuilds, andexamples/javascript-webbuildsunder vite 8.1.4.
Fixes #362
Type of Change