Skip to content

chore(deps): bump vite to ^8.1.4#398

Open
rohanshrma222 wants to merge 6 commits into
usemoss:mainfrom
rohanshrma222:vite
Open

chore(deps): bump vite to ^8.1.4#398
rohanshrma222 wants to merge 6 commits into
usemoss:mainfrom
rohanshrma222:vite

Conversation

@rohanshrma222

@rohanshrma222 rohanshrma222 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Please ensure that your PR meets the following requirements:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation (if applicable).
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Description

Bumps vite to ^8.1.4 across all manifests (devDependencies and pnpm/npm overrides) and regenerates the corresponding lockfiles: root,
examples/javascript-web, moss-live-labs/examples/image-search/react-app, packages/moss-md-indexer (and its example/), and
packages/vitepress-plugin-moss (and its demo-site/).

Also adds @vue/language-core as an explicit devDependency in packages/vitepress-plugin-moss it's an optional peer of unplugin-dts (via
vite-plugin-dts) that was previously pulled into the dependency graph transitively, but stopped being resolved after the vite bump, breaking
the .d.ts build. Declaring it explicitly (pinned to ^3.2.7, matching the existing pnpm.overrides entry) fixes it.

Verified vitepress-plugin-moss builds and its test suite (45 tests) passes, moss-md-indexer builds, and examples/javascript-web builds
under vite 8.1.4.

Fixes #362

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo’s JavaScript/Vite-based subprojects to use vite ^8.1.4 (including overrides) and regenerates the associated lockfiles, plus adds an explicit @vue/language-core devDependency to keep the packages/vitepress-plugin-moss TypeScript declaration build working.

Changes:

  • Bump vite to ^8.1.4 across relevant package.json manifests and pnpm/npm overrides.
  • Regenerate pnpm-lock.yaml / package-lock.json files for affected workspaces.
  • Add @vue/language-core as an explicit devDependency for vitepress-plugin-moss to stabilize .d.ts generation.

Reviewed changes

Copilot reviewed 7 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/vitepress-plugin-moss/pnpm-lock.yaml Updates resolved dependency graph for vitepress-plugin-moss after Vite 8 bump (plus @vue/language-core resolution).
packages/vitepress-plugin-moss/package.json Bumps Vite dependency/overrides and adds explicit @vue/language-core devDependency.
packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml Updates demo-site lockfile for Vite 8 bump and resulting transitive changes.
packages/vitepress-plugin-moss/demo-site/package.json Updates pnpm override to vite: ^8.1.4.
packages/moss-md-indexer/pnpm-lock.yaml Updates @moss-tools/md-indexer lockfile to reflect Vite 8 override impacts.
packages/moss-md-indexer/package.json Updates vite overrides to ^8.1.4.
packages/moss-md-indexer/example/package.json Updates example overrides to vite: ^8.1.4.
package.json Updates root overrides to vite: ^8.1.4.
moss-live-labs/examples/image-search/react-app/package.json Bumps Vite in the react-app devDependencies to ^8.1.4.
moss-live-labs/examples/image-search/react-app/package-lock.json Regenerated npm lockfile reflecting Vite 8.1.4 and updated transitive deps.
examples/javascript-web/package.json Bumps Vite devDependency to ^8.1.4.
examples/javascript-web/package-lock.json Regenerated npm lockfile reflecting Vite 8.1.4 and updated transitive deps.
Files not reviewed (6)
  • examples/javascript-web/package-lock.json: Generated file
  • moss-live-labs/examples/image-search/react-app/package-lock.json: Generated file
  • packages/moss-md-indexer/example/pnpm-lock.yaml: Generated file
  • packages/moss-md-indexer/pnpm-lock.yaml: Generated file
  • packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml: Generated file
  • packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 12 to 16
"overrides": {
"esbuild": "^0.28.0",
"postcss": "^8.5.16",
"vite": "^6.4.2"
"vite": "^8.1.4"
}
@@ -49,8 +49,9 @@
"@microsoft/api-extractor": "^7.58.7",
"@types/node": "^20.0.0",
Comment on lines +52 to 55
"@vue/language-core": "^3.2.7",
"typescript": "^5.0.0",
"vite": "^6.4.3",
"vite": "^8.1.4",
"vite-plugin-dts": "^5.0.0",
Comment on lines 16 to 19
"devDependencies": {
"typescript": "^5.7.0",
"vite": "^8.0.16"
"vite": "^8.1.4"
}

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (6)
  • examples/javascript-web/package-lock.json: Generated file
  • moss-live-labs/examples/image-search/react-app/package-lock.json: Generated file
  • packages/moss-md-indexer/example/pnpm-lock.yaml: Generated file
  • packages/moss-md-indexer/pnpm-lock.yaml: Generated file
  • packages/vitepress-plugin-moss/demo-site/pnpm-lock.yaml: Generated file
  • packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

packages/vitepress-plugin-moss/package.json:42

  • package.json now enforces Node >=20.19.0, but peerDependencies still declare compatibility with vite >=5 and vitepress >=1. That combination is internally inconsistent: consumers running older (but still peer-allowed) vite/vitepress versions on Node 18/20.0 would be blocked by the engines field even if the runtime code would otherwise work.

Either tighten the peerDependency ranges to match the Node floor implied by the tooling (e.g., require vite 8+), or relax/remove the engines constraint if the published package’s runtime still supports older Node versions.

  "engines": {
    "node": ">=20.19.0"
  },
  "peerDependencies": {
    "vite": ">=5.0.0",
    "vitepress": ">=1.0.0"
  },

Comment on lines +1 to +5
allowBuilds:
esbuild: true
protobufjs: false
overrides:
"@vue/language-core": "^3.2.7"
@HarshaNalluru

Copy link
Copy Markdown
Contributor

@rohanshrma222 please resolve comments

@rohanshrma222

Copy link
Copy Markdown
Contributor Author

@rohanshrma222 please resolve comments

on it

@rohanshrma222

Copy link
Copy Markdown
Contributor Author

Fixed merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update vite to the latest version

3 participants