Repository navigation
Build the installed-package test fixture with tsc instead of copying dist/, so npm test passes in release.yml, which never builds (unblocks v0.6.0's publish) - #20
Merged
Conversation
…, which npm test alone (release.yml) never produces Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only — the
installed under node_modulestest from #19 no longer depends ondist/existing, sonpm testpasses in release.yml, which runs tests beforeprepackbuilds. The v0.6.0 publish job failed on it withENOENT ... lstat '.../dist'.Fix
The test's
beforeAllrunstsc -p tsconfig.build.json --outDir <fixture>/node_modules/@useblacksmith/vitest/distitself instead ofcpSync(packageRoot/dist, ...). The copy is also always fresh, where a stale localdist/could have tested old code.Evidence
rm -rf dist && npx vitest run -t "installed under node_modules"passes locally; the fullnpm testpassed on #19's CI, which builds first, and this is the only test touchingdist/.Risks
tscrun (~3 s) to the suite.Link to Devin session: https://app.devin.ai/sessions/908e16d5e5d54e2c968498f368f535d8
Open in Devin Desktop: https://app.devin.ai/desktop/session/908e16d5e5d54e2c968498f368f535d8?variant=devin
Requested by: @max-blacksmith
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need. (Staging)🟢 Devin Review found nothing to fix · View findings