Skip to content

Build the installed-package test fixture with tsc instead of copying dist/, so npm test passes in release.yml, which never builds (unblocks v0.6.0's publish) - #20

Merged
max-blacksmith merged 1 commit into
mainfrom
devin/1794518075-test-builds-dist
Nov 12, 2026
Merged

max-blacksmith merged 1 commit into
mainfrom
devin/1794518075-test-builds-dist

Conversation

@max-blacksmith

@max-blacksmith max-blacksmith commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Tests only — the installed under node_modules test from #19 no longer depends on dist/ existing, so npm test passes in release.yml, which runs tests before prepack builds. The v0.6.0 publish job failed on it with ENOENT ... lstat '.../dist'.

Fix

The test's beforeAll runs tsc -p tsconfig.build.json --outDir <fixture>/node_modules/@useblacksmith/vitest/dist itself instead of cpSync(packageRoot/dist, ...). The copy is also always fresh, where a stale local dist/ could have tested old code.

Evidence

rm -rf dist && npx vitest run -t "installed under node_modules" passes locally; the full npm test passed on #19's CI, which builds first, and this is the only test touching dist/.

Risks

  • Adds one tsc run (~3 s) to the suite.

Link to Devin session: https://app.devin.ai/sessions/908e16d5e5d54e2c968498f368f535d8
Open in Devin Desktop: https://app.devin.ai/desktop/session/908e16d5e5d54e2c968498f368f535d8?variant=devin
Requested by: @max-blacksmith


Prove it works
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need. (Staging)


🟢 Devin Review found nothing to fix · View findings

Devin Review

…, which npm test alone (release.yml) never produces

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@max-blacksmith
max-blacksmith merged commit 046e8cf into main Nov 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant