Skip to content

dockerfile: verify sha256 of downloaded cni plugins and test scripts - #38

Merged
rcooney-sh merged 1 commit into
masterfrom
vulnagent/hygiene-2026-09-cni-checksum
Oct 28, 2026
Merged

rcooney-sh merged 1 commit into
masterfrom
vulnagent/hygiene-2026-09-cni-checksum

Conversation

@rcooney-sh

@rcooney-sh rcooney-sh commented Sep 24, 2026 •

Copy link
Copy Markdown

The CNI tarball feeds shipped BuildKit binaries but was extracted without integrity verification. Download to a file, check pinned SHA-256 checksums for seven v1.9.1 Linux architectures, then extract. Verify the test-only rootless and dind scripts too. Unknown versions or architectures fail closed.

echo "${sha256}  /tmp/${tarball}" | sha256sum -c -

tar xzvf "/tmp/${tarball}"

Covered problem IDs: prb_19a79982abec5b8b. Linear: SEC-701. Aikido findings: 543472724, 543472725, 543472727.

Promotion risk: Low. Build-time integrity checks only. The bytes that ship are the same upstream artifacts as before.

  • Runtime change: none. buildkitd and the CNI plugins in the release are built from the same v1.9.1 tarball; the build now fails if its sha256 does not match. The rootless and dind script checks only affect the integration-test image.
  • What could break: the build, not production. Bumping CNI_VERSION or NERDCTL_VERSION, or adding an architecture, without new checksums fails closed with no pinned sha256 for .... An upstream re-upload of a release asset would fail the same way.
  • Evidence: CNI hashes cross-checked against upstream .sha256 assets and GitHub digests. CI built the release and integration-test stages; every integration shard on that image passed except integration gateway, a known intermittent failure. Not exercised: the tag-triggered release publish.
  • Blast radius / rollback / watch: nothing reaches runner hosts until a new -blacksmith tag is cut and fa's buildkit pins are bumped and rolled. It can ride the same tag as vendor: update grpc to v1.83.2 and go directive to 1.26 #42 (no file overlap). Roll back by reverting before the next tag. Watch the release workflow on the next tag.

View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled. (Staging)


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

The cni-plugins tarball ships in the release binaries but was extracted
straight from curl with no integrity check. Pin per-architecture sha256
checksums (matching upstream's published .sha256 files) and verify
before extracting. Apply the same check to the containerd-rootless.sh
and dind scripts fetched into integration-tests-base.

Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

SEC-701

@rcooney-sh
rcooney-sh merged commit 6148a6d into master Oct 28, 2026
309 of 313 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants