Repository navigation
dockerfile: verify sha256 of downloaded cni plugins and test scripts - #38
Merged
Merged
Conversation
The cni-plugins tarball ships in the release binaries but was extracted straight from curl with no integrity check. Pin per-architecture sha256 checksums (matching upstream's published .sha256 files) and verify before extracting. Apply the same check to the containerd-rootless.sh and dind scripts fetched into integration-tests-base. Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
piob-io
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CNI tarball feeds shipped BuildKit binaries but was extracted without integrity verification. Download to a file, check pinned SHA-256 checksums for seven v1.9.1 Linux architectures, then extract. Verify the test-only rootless and dind scripts too. Unknown versions or architectures fail closed.
Covered problem IDs: prb_19a79982abec5b8b. Linear: SEC-701. Aikido findings: 543472724, 543472725, 543472727.
Promotion risk: Low. Build-time integrity checks only. The bytes that ship are the same upstream artifacts as before.
CNI_VERSIONorNERDCTL_VERSION, or adding an architecture, without new checksums fails closed withno pinned sha256 for .... An upstream re-upload of a release asset would fail the same way..sha256assets and GitHub digests. CI built the release and integration-test stages; every integration shard on that image passed exceptintegration gateway, a known intermittent failure. Not exercised: the tag-triggered release publish.-blacksmithtag is cut and fa's buildkit pins are bumped and rolled. It can ride the same tag as vendor: update grpc to v1.83.2 and go directive to 1.26 #42 (no file overlap). Roll back by reverting before the next tag. Watch the release workflow on the next tag.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.