docs(knative): update to newer Go and Knative versions#438
docs(knative): update to newer Go and Knative versions#438ishaanxgupta wants to merge 2 commits intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@cmainas please have a look and let me know if any changes are required |
- Update Go version from 1.21.5 to use dynamic [[ versions.go ]] template (currently 1.24.6) - Update Knative version to use [[ versions.knative ]] template (currently 1.17.0) - Restructure installation to prioritize pre-built binaries (Option 1) - Simplify Go and ko installation instructions - Add ko version verification step - Improve clarity of pre-built vs source build options Fixes: urunc-dev#430 Signed-off-by: hemang1404 <hemangsharrma@gmail.com> Co-authored-by: ishaanxgupta <ishaankone@gmail.com>
f74e0c9 to
70ff35e
Compare
|
Hello @ishaanxgupta , please try to create a knative environment with your suggested changes and provide enough proof that this works. |
|
Duplicate with #433 |
|
Hi @cmainas
Test Environment
Results
|
cmainas
left a comment
There was a problem hiding this comment.
Thank you @ishaanxgupta and @hemang1404 for testing this. I have a left comment for the structure of the tutorial. I have also verified that it works. A few more notes:
- We can add an instruction to get the ingress IP. Simply transforming the note that starts with
Note: 10.244.9.220 is the IP of the kourier-internal svc.to an instruction before invoking the function - I think we can remove the
Wrapping upsection
docs/tutorials/knative.md
Outdated
| ``` | ||
|
|
||
| ### Clone urunc-enabled Knative Serving | ||
| ### Option 1: Use Pre-built Knative (Recommended) |
There was a problem hiding this comment.
This looks good, but if users decide not to build Knative, then there is no reason to installl docker, go and ko. Therefore, it would be better to move this further up before installing anything and adjusting the text.
There was a problem hiding this comment.
Also, we will need to adjust the prerequisites, to keep them as a working K8s and urunc installation and move the "Basic git, curl, kubectl, and docker installed" to the option that builds knative from scratch.
Co-authored-by: Ishaan Gupta <ishaankone@gmail.com> Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
ac05dc5 to
e91074f
Compare



Description
This PR updates the Knative integration tutorial to use the latest versions and improves the documentation structure
Related issues
How was this tested?
LLM usage
GitHub Copilot assisted with code review.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).collaborated with @hemang1404