Skip to content

docs(knative): update to newer Go and Knative versions#438

Open
ishaanxgupta wants to merge 2 commits intourunc-dev:mainfrom
hemang1404:fix-knative-tutorial-430
Open

docs(knative): update to newer Go and Knative versions#438
ishaanxgupta wants to merge 2 commits intourunc-dev:mainfrom
hemang1404:fix-knative-tutorial-430

Conversation

@ishaanxgupta
Copy link
Contributor

Description

This PR updates the Knative integration tutorial to use the latest versions and improves the documentation structure

  • Update Go version from 1.21.5 to use dynamic [[ versions.go ]] template (currently 1.24.6)
  • Update Knative version to use [[ versions.knative ]] template (currently 1.17.0)
  • Restructure installation to prioritize pre-built binaries (Option 1)
  • Simplify Go and ko installation instructions
  • Add ko version verification step
  • Improve clarity of pre-built vs source build options

Related issues

How was this tested?

  • Verified template syntax matches mkdocs.yml configuration (j2_variable_start_string: "[[")
  • Confirmed versions.go and versions.knative variables exist in docs/variables/versions.yml
  • Checked consistency with other tutorials (e.g., Running-urunc-with-kind.md uses same template pattern)
  • Validated pre-built S3 URL format matches original format (with -5220308.yaml suffix)
  • Ensured source build option still uses nubificus/serving -b feat_urunc to preserve urunc patches
  • Reviewed all changes for accuracy and completeness

LLM usage

GitHub Copilot assisted with code review.

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

collaborated with @hemang1404

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for urunc ready!

Name Link
🔨 Latest commit e91074f
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6987bc1315fc9f0008841207
😎 Deploy Preview https://deploy-preview-438--urunc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ishaanxgupta
Copy link
Contributor Author

@cmainas please have a look and let me know if any changes are required

- Update Go version from 1.21.5 to use dynamic [[ versions.go ]] template (currently 1.24.6)
- Update Knative version to use [[ versions.knative ]] template (currently 1.17.0)
- Restructure installation to prioritize pre-built binaries (Option 1)
- Simplify Go and ko installation instructions
- Add ko version verification step
- Improve clarity of pre-built vs source build options

Fixes: urunc-dev#430

Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
Co-authored-by: ishaanxgupta <ishaankone@gmail.com>
@hemang1404 hemang1404 force-pushed the fix-knative-tutorial-430 branch from f74e0c9 to 70ff35e Compare February 3, 2026 18:25
@cmainas
Copy link
Contributor

cmainas commented Feb 4, 2026

Hello @ishaanxgupta ,

please try to create a knative environment with your suggested changes and provide enough proof that this works.

@cmainas
Copy link
Contributor

cmainas commented Feb 4, 2026

Duplicate with #433

@cmainas cmainas added the duplicate This issue or pull request already exists label Feb 4, 2026
@ishaanxgupta
Copy link
Contributor Author

ishaanxgupta commented Feb 6, 2026

Hi @cmainas
Here are the validation results tested by me and @hemang1404

image image image

Test Environment

  • OS: Ubuntu 22.04 (WSL2)
  • Kubernetes: Kind v0.32.0

Results

  • go version go1.24.6 linux/amd64
  • Template [[ versions.go ]] correctly resolves to 1.24.6 from versions.yml
  • Simplified installation using /latest/ works correctly
  • Knative v1.17.0 Deployed
  • Pre-built Knative v1.17.0 URL works correctly
  • Template variable [[ versions.knative ]] resolves properly
  • All Knative components deploy successfully

Copy link
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ishaanxgupta and @hemang1404 for testing this. I have a left comment for the structure of the tutorial. I have also verified that it works. A few more notes:

  • We can add an instruction to get the ingress IP. Simply transforming the note that starts with Note: 10.244.9.220 is the IP of the kourier-internal svc. to an instruction before invoking the function
  • I think we can remove the Wrapping upsection

```

### Clone urunc-enabled Knative Serving
### Option 1: Use Pre-built Knative (Recommended)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but if users decide not to build Knative, then there is no reason to installl docker, go and ko. Therefore, it would be better to move this further up before installing anything and adjusting the text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we will need to adjust the prerequisites, to keep them as a working K8s and urunc installation and move the "Basic git, curl, kubectl, and docker installed" to the option that builds knative from scratch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Co-authored-by: Ishaan Gupta <ishaankone@gmail.com>
Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
@hemang1404 hemang1404 force-pushed the fix-knative-tutorial-430 branch from ac05dc5 to e91074f Compare February 7, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Knative tutorial

3 participants