Skip to content

Fix missing increment on checked len for crc calculator #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdumandag merged 1 commit into from
Nov 11, 2025
Merged

Fix missing increment on checked len for crc calculator #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions buffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ func (c *crcCalculator) Update(b []byte) {
}

c.crc = getCRC(c.crc, b)
c.checkedLen += len(b)
}

func (c *crcCalculator) Crc() uint64 {
Expand Down
Binary file added testdata/dumps/big.rdb
View file
Open in desktop
Binary file not shown.
24 changes: 15 additions & 9 deletions verify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ var stringRDBValuePath = filepath.Join(valueDumpsPath, "string.bin")
var streamWithPELRDBValuePath = filepath.Join(valueDumpsPath, "stream-listpacks3.bin")
var multiDBRDBPath = filepath.Join(dumpsPath, "multi-db.rdb")
var withPaddingRDBPath = filepath.Join(dumpsPath, "with-padding.rdb")
var bigDumpPath = filepath.Join(dumpsPath, "big.rdb")

func TestVerifyFile(t *testing.T) {
err := VerifyFile(allTypesRDBPath, VerifyFileOptions{})
Expand Down Expand Up @@ -83,6 +84,11 @@ func TestVerifyFile_maxStreamPELSize(t *testing.T) {
require.ErrorContains(t, err, "max stream pel size")
}

func TestVerifyFile_biggerThanBufferSizeFile(t *testing.T) {
err := VerifyFile(bigDumpPath, VerifyFileOptions{})
require.NoError(t, err)
}

func TestVerifyValue(t *testing.T) {
dump, err := os.ReadFile(stringRDBValuePath)
require.NoError(t, err)
Expand Down Expand Up @@ -121,7 +127,7 @@ func TestVerifyReader(t *testing.T) {
file, err := os.Open(allTypesRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{})
Expand All @@ -132,7 +138,7 @@ func TestVerifyReader_withPEL(t *testing.T) {
file, err := os.Open(streamWithPELRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{})
Expand All @@ -143,7 +149,7 @@ func TestReaderFile_maxDataSize(t *testing.T) {
file, err := os.Open(allTypesRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand All @@ -156,7 +162,7 @@ func TestVerifyReader_maxEntrySize(t *testing.T) {
file, err := os.Open(allTypesRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand All @@ -169,7 +175,7 @@ func TestVerifyReader_maxKeySize(t *testing.T) {
file, err := os.Open(allTypesRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand All @@ -182,7 +188,7 @@ func TestVerifyReader_maxStreamPELSize(t *testing.T) {
file, err := os.Open(streamWithPELRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand All @@ -195,7 +201,7 @@ func TestVerifyReader_BadCrc(t *testing.T) {
file, err := os.Open(badCrcRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{})
Expand All @@ -206,7 +212,7 @@ func TestVerifyReader_AllowPartialRead(t *testing.T) {
file, err := os.Open(multiDBRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand All @@ -227,7 +233,7 @@ func TestVerifyReader_RequireStrictEOF(t *testing.T) {
file, err := os.Open(withPaddingRDBPath)
require.NoError(t, err)
t.Cleanup(func() {
file.Close()
_ = file.Close()
})

err = VerifyReader(file, VerifyReaderOptions{
Expand Down