Skip to content

fix(memory): drop per-search lastAccessed write causing Lance concurrent-writer errors #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unohee merged 1 commit into from
Jul 16, 2026
Merged

fix(memory): drop per-search lastAccessed write causing Lance concurrent-writer errors #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/memory/memoryCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,16 @@ export async function searchMemorySafe(
.sort((a, b) => b.hybridScore - a.hybridScore)
.slice(0, limit);

updateAccessTime(scored.map(s => s.record.id)).catch((e) => console.warn('[Memory] Failed to update access time:', e));
// NOTE: we deliberately do NOT write a `lastAccessed` timestamp back here.
// Every search used to fire a Lance `table.update()` commit, but `lastAccessed`
// feeds nothing — retrieval recency uses `createdAt` (access-frequency/decay was
// removed, see calculateFreshness below), and no CLI reads the field. Under
// `openswarm review --max` (up to 16 concurrent reviewer subagents each searching
// memory) those per-search commits collided on Lance's optimistic-concurrency
// limit → "Too many concurrent writers … [Memory] Failed to update access time".
// Dropping a write with no read consumer removes the contention entirely. The
// schema field remains (set at record creation) so decay can be reintroduced with
// a batched/serialized writer if ever needed.

const formatted: MemorySearchResult[] = scored.map(({ record: r, similarity, recency, importance, hybridScore }) => ({
id: r.id,
Expand Down Expand Up @@ -952,16 +961,3 @@ export async function searchMemory(
return result.memories;
}

/**
* Update last_accessed timestamp for retrieved memories
*/
async function updateAccessTime(ids: string[]): Promise<void> {
if (!table || ids.length === 0) return;

const uniqueIds = [...new Set(ids)];
const quotedIds = uniqueIds.map(id => `'${String(id).replace(/'/g, "''")}'`).join(', ');
await table.update({
where: `id IN (${quotedIds})`,
values: { lastAccessed: Date.now() },
});
}
Loading