Skip to content

docs: #1153 - add initial non-isothermal condensation planning artifacts#1155

Merged
Gorkowski merged 2 commits into
uncscode:mainfrom
Gorkowski:issue-1153-adw-600b6808
Jun 6, 2026
Merged

docs: #1153 - add initial non-isothermal condensation planning artifacts#1155
Gorkowski merged 2 commits into
uncscode:mainfrom
Gorkowski:issue-1153-adw-600b6808

Conversation

@Gorkowski

Copy link
Copy Markdown
Collaborator

Target Branch: main

Fixes #1153 | Workflow: 600b6808

Summary

Adds the first structured planning artifacts for the non-isothermal condensation epic under .opencode/plans/. The PR captures the epic record (E1), the first feature record (E1-F1), and the canonical section-file layout needed for follow-on planning work. This gives the issue a committed planning footprint even though the planner run did not complete the full multi-track draft.

What Changed

New Components

  • .opencode/plans/epics/E1.json - Canonical epic metadata for the non-isothermal condensation planning effort
  • .opencode/plans/features/E1-F1.json - Canonical feature metadata for the first child track covering public builder/factory support
  • .opencode/plans/sections/epics/E1/ - Epic section set for scope, risks, milestones, implementation strategy, and related planning views
  • .opencode/plans/sections/features/E1-F1/ - Feature section set for architecture, implementation tasks, testing strategy, docs updates, and rollout planning

Modified Components

  • None. This PR adds new planning artifacts only.

Tests Added/Updated

  • No repository tests were added or changed
  • Pre-commit hooks passed during commit creation

How It Works

The planner output is stored as a two-layer plan structure:

GitHub Issue #1153
    │
    └──▶ Epic record: `.opencode/plans/epics/E1.json`
              │
              ├──▶ Epic section files
              │     ├── vision_problem.md
              │     ├── scope_constraints.md
              │     ├── implementation_strategy.md
              │     └── ...
              │
              └──▶ Feature record: `.opencode/plans/features/E1-F1.json`
                        │
                        └──▶ Feature section files
                              ├── overview.md
                              ├── architecture_design.md
                              ├── implementation_tasks.md
                              └── ...

This separates machine-readable plan metadata (*.json) from human-edited planning sections (*.md) so later planning and implementation workflows can update each layer independently.

Implementation Notes

  • Why this approach: It follows the structured .opencode/plans/ layout used by the ADW planning system and gives the issue durable epic/feature IDs for follow-on work.
  • Deviations from issue: The planner did not complete the full requested multi-track draft. The committed output currently includes the epic plus the first feature track scaffold; research-track creation failed, and several section files remain template-derived placeholders.
  • Reviewer focus: Confirm the initial plan IDs, file placement, and whether the partial scaffold is acceptable as a checkpoint PR for continuing planning work.

Testing

  • Pre-commit validation: Passed during adw-commit
  • Manual verification: Confirmed the branch contains the new .opencode/plans/ epic/feature records and section directories
  • Runtime impact: None; this PR adds planning artifacts only

Add epic E1 and feature E1-F1 planning documents for the
non-isothermal condensation API work.

Capture scope, architecture, implementation tasks, testing,
documentation updates, and risks so the issue has structured
execution guidance and review context.

Closes uncscode#1153

ADW-ID: 600b6808
Copilot AI review requested due to automatic review settings June 6, 2026 19:13
@Gorkowski Gorkowski added agent Created or managed by ADW automation blocked Blocked - review required before ADW can process labels Jun 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the initial structured planning scaffold for the non-isothermal condensation epic (#1153) under .opencode/plans/, including canonical epic/feature JSON records and the corresponding section-file directory layout for follow-on planning work.

Changes:

  • Added epic plan record E1 plus epic section markdown scaffold under .opencode/plans/sections/epics/E1/
  • Added feature plan record E1-F1 plus feature section markdown scaffold under .opencode/plans/sections/features/E1-F1/
  • Established the canonical section_files mapping for both plans to support subsequent planning updates

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.opencode/plans/epics/E1.json Adds canonical epic metadata record for E1
.opencode/plans/features/E1-F1.json Adds canonical feature metadata record for E1-F1
.opencode/plans/sections/epics/E1/vision_problem.md Epic vision/problem section scaffold
.opencode/plans/sections/epics/E1/scope_constraints.md Epic scope/constraints section scaffold
.opencode/plans/sections/epics/E1/implementation_strategy.md Epic implementation/testing requirements scaffold
.opencode/plans/sections/epics/E1/success_metrics.md Epic success metrics section scaffold
.opencode/plans/sections/epics/E1/risk_register.md Epic risk register section scaffold
.opencode/plans/sections/epics/E1/outcomes_guardrails.md Epic outcomes/guardrails section scaffold
.opencode/plans/sections/epics/E1/open_questions.md Epic open questions section scaffold
.opencode/plans/sections/epics/E1/milestones_timeline.md Epic milestones/timeline section scaffold
.opencode/plans/sections/epics/E1/governance.md Epic governance log section scaffold
.opencode/plans/sections/epics/E1/dependency_map.md Epic dependency map section scaffold
.opencode/plans/sections/epics/E1/child_plans.md Epic child plans index section scaffold
.opencode/plans/sections/epics/E1/change_log.md Epic change log section scaffold
.opencode/plans/sections/epics/E1/appendix.md Epic appendix section scaffold
.opencode/plans/sections/features/E1-F1/overview.md Feature overview section scaffold
.opencode/plans/sections/features/E1-F1/scope.md Feature scope section scaffold
.opencode/plans/sections/features/E1-F1/infrastructure_reuse.md Feature reuse/integration pointers scaffold
.opencode/plans/sections/features/E1-F1/phase_details.md Feature phase checklist scaffold
.opencode/plans/sections/features/E1-F1/architecture_design.md Feature architecture/design section scaffold
.opencode/plans/sections/features/E1-F1/implementation_tasks.md Feature implementation task breakdown scaffold
.opencode/plans/sections/features/E1-F1/dependencies.md Feature dependency mapping scaffold
.opencode/plans/sections/features/E1-F1/testing_strategy.md Feature testing strategy scaffold
.opencode/plans/sections/features/E1-F1/documentation_updates.md Feature documentation update plan scaffold
.opencode/plans/sections/features/E1-F1/success_criteria.md Feature success criteria scaffold
.opencode/plans/sections/features/E1-F1/risk_register.md Feature risk register section stub
.opencode/plans/sections/features/E1-F1/open_questions.md Feature open questions section scaffold
.opencode/plans/sections/features/E1-F1/change_log.md Feature change log section scaffold

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .opencode/plans/features/E1-F1.json Outdated
Comment on lines +31 to +33
"phases": [],
"totals": null,
"lifecycle": "active"
Comment thread .opencode/plans/epics/E1.json Outdated
Comment on lines +33 to +34
"risk_register": [],
"lifecycle": "active"
**Example:**
- [ ] Should child feature plans share a single tracking branch or use separate branches?
- Resolved 2026-04-01: Separate branches per feature, accumulated into the epic branch
- [ ] How should cross-epic dependencies be tracked when two epics share a feature?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be in sequence

@Gorkowski Gorkowski added request:plan-fix Request AI to apply follow-up fixes for planner output adw:in-progress ADW workflow actively processing - remove to re-trigger and removed blocked Blocked - review required before ADW can process labels Jun 6, 2026
@Gorkowski

Gorkowski commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Agent Developer Workflow

  • Description: Plan-fix workflow: analyze comments -> revise plans -> re-review -> ship -> generate issues
  • ADW ID: 7b9dbdd9
  • Current Phase: Workflow completed successfully
  • Started: 2026-06-06T21:47:41.403476Z
  • Last Update: 2026-06-06T22:13:19.170583Z

Current Status

  • Workflow completed in 25m 36s

Workflow Plan

  • ✅ Analyze Comments (at 2026-06-06T21:50:01.578301Z)
  • ✅ Revise Plans (at 2026-06-06T21:51:20.196961Z)
  • ✅ Re-split Phases (at 2026-06-06T21:52:22.304685Z)
  • ✅ Review Architecture (at 2026-06-06T21:55:59.727128Z)
  • ✅ Review Sizing (at 2026-06-06T21:59:43.205430Z)
  • ✅ Review Testing (at 2026-06-06T22:01:22.962001Z)
  • ✅ Review Dependencies (at 2026-06-06T22:03:28.217610Z)
  • ✅ Review Completeness (at 2026-06-06T22:06:31.421944Z)
  • ✅ Consistency Check (at 2026-06-06T22:08:32.195174Z)
  • ✅ Ship Fix (at 2026-06-06T22:11:14.791335Z)
  • ✅ Generate Issues (at 2026-06-06T22:13:17.577457Z)
📋 Recent Activity
[2026-06-06T22:03:28.217636Z] Completed step 7/11: Review Dependencies
[2026-06-06T22:03:29.847758Z] Starting step 8/11: Review Completeness
[2026-06-06T22:06:31.421973Z] Completed step 8/11: Review Completeness
[2026-06-06T22:06:33.064889Z] Starting step 9/11: Consistency Check
[2026-06-06T22:08:32.195203Z] Completed step 9/11: Consistency Check
[2026-06-06T22:08:33.990812Z] Starting step 10/11: Ship Fix
[2026-06-06T22:11:14.791350Z] Completed step 10/11: Ship Fix
[2026-06-06T22:11:16.476600Z] Starting step 11/11: Generate Issues
[2026-06-06T22:13:17.577482Z] Completed step 11/11: Generate Issues
[2026-06-06T22:13:19.170352Z] Workflow plan-fix finished: 11/11 steps completed
🔍 Archived Updates
[2026-06-06T21:47:41.439035Z] Workflow plan-fix started with 11 steps
[2026-06-06T21:47:43.345896Z] Starting step 1/11: Analyze Comments
[2026-06-06T21:50:01.578321Z] Completed step 1/11: Analyze Comments
[2026-06-06T21:50:03.220005Z] Starting step 2/11: Revise Plans
[2026-06-06T21:51:20.196985Z] Completed step 2/11: Revise Plans
[2026-06-06T21:51:21.814990Z] Starting step 3/11: Re-split Phases
[2026-06-06T21:52:22.304705Z] Completed step 3/11: Re-split Phases
[2026-06-06T21:52:23.862315Z] Starting step 4/11: Review Architecture
[2026-06-06T21:55:59.727153Z] Completed step 4/11: Review Architecture
[2026-06-06T21:56:01.337425Z] Starting step 5/11: Review Sizing
[2026-06-06T21:59:43.205452Z] Completed step 5/11: Review Sizing
[2026-06-06T21:59:44.784744Z] Starting step 6/11: Review Testing
[2026-06-06T22:01:22.962017Z] Completed step 6/11: Review Testing
[2026-06-06T22:01:24.554142Z] Starting step 7/11: Review Dependencies

This comment is automatically updated as the workflow progresses

Remove unsupported lifecycle fields from the E1 and E1-F1 plan
records and replace template placeholders with scoped planning
content.

Clarify phase sequencing, dependencies, success metrics, risks,
and open questions so the epic and feature plans reflect the
current latent-heat condensation design review.

Closes uncscode#1155

ADW-ID: 7b9dbdd9
@Gorkowski

Copy link
Copy Markdown
Collaborator Author

Fix Summary

Applied the requested plan-fix updates from review feedback on PR #1155 and pushed the changes to the existing branch.

Changes Made

  • Removed unsupported lifecycle metadata from the epic and feature plan records so schema validation passes.
  • Reordered the epic open questions so the entries are presented sequentially.
  • Completed the follow-up plan polishing from the review passes, including architecture, dependency, sizing, testing, completeness, and consistency updates across the E1 / E1-F1 planning docs.
  • Commit pushed: 4212de549 (chore(plans): align E1 plan docs with review feedback)

Review Comments Addressed

  • Comment 3368080992: removed the unsupported lifecycle field from .opencode/plans/features/E1-F1.json.
  • Comment 3368081014: removed the unsupported lifecycle field from .opencode/plans/epics/E1.json.
  • Comment 3368298770: reordered .opencode/plans/sections/epics/E1/open_questions.md to present questions sequentially.

Files Changed

Diff vs main: 28 files changed, 673 insertions(+)

Primary touched files:

  • .opencode/plans/epics/E1.json
  • .opencode/plans/features/E1-F1.json
  • .opencode/plans/sections/epics/E1/change_log.md
  • .opencode/plans/sections/epics/E1/dependency_map.md
  • .opencode/plans/sections/epics/E1/implementation_strategy.md
  • .opencode/plans/sections/epics/E1/milestones_timeline.md
  • .opencode/plans/sections/epics/E1/open_questions.md
  • .opencode/plans/sections/epics/E1/risk_register.md
  • .opencode/plans/sections/epics/E1/success_metrics.md
  • .opencode/plans/sections/features/E1-F1/architecture_design.md
  • .opencode/plans/sections/features/E1-F1/change_log.md
  • .opencode/plans/sections/features/E1-F1/dependencies.md
  • .opencode/plans/sections/features/E1-F1/implementation_tasks.md
  • .opencode/plans/sections/features/E1-F1/open_questions.md
  • .opencode/plans/sections/features/E1-F1/phase_details.md
  • .opencode/plans/sections/features/E1-F1/risk_register.md
  • .opencode/plans/sections/features/E1-F1/success_criteria.md
  • .opencode/plans/sections/features/E1-F1/testing_strategy.md

Automated fix by ADW workflow 7b9dbdd9

@Gorkowski Gorkowski merged commit 5e974ed into uncscode:main Jun 6, 2026
7 checks passed
@Gorkowski Gorkowski deleted the issue-1153-adw-600b6808 branch June 6, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adw:in-progress ADW workflow actively processing - remove to re-trigger agent Created or managed by ADW automation request:plan-fix Request AI to apply follow-up fixes for planner output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Planner]: Complete Non-Isothermal Condensation Public API, Validation, Documentation, and Acceleration Readiness

2 participants