2.06 - Fixed problem with Json parsing. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run into an issue with the invalid location detection when writting my response and short after with the solution here at 2.06. The preference `location-state` never was changing to invalid location because the `getInputStream()` method throws a FileNotFoudException therefore not giving the method `getWeatherDataFromJson` the oportunity to retrieve the property `cod` containing the 404 we were looking for. The solution is to use `getErrorStream` to parse the "error" server response and handle the 404 ourselves. Ps: Also removed some warnings (null checks and similar).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into an issue with the invalid location detection when writting my response and short after with the solution here at 2.06.
The preference
location-statenever was changing to invalid location because thegetInputStream()method throws a FileNotFoudException therefore not giving the methodgetWeatherDataFromJsonthe oportunity to retrieve the propertycodcontaining the 404 we were looking for.The solution is to use
getErrorStreamto parse the "error" server response and handle the 404 ourselves.Ps: Also removed some warnings (null checks and similar).