Skip to content

Extract data from bundle directly #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singh-sarabjeet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extract data from bundle directly #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions app/src/main/java/com/example/android/sunshine/app/gcm/MyGcmListenerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public class MyGcmListenerService extends GcmListenerService {

private static final String TAG = "MyGcmListenerService";

private static final String EXTRA_DATA = "data";
private static final String EXTRA_WEATHER = "weather";
private static final String EXTRA_LOCATION = "location";

Expand All @@ -63,17 +62,11 @@ public void onMessageReceived(String from, Bundle data) {
// Not a bad idea to check that the message is coming from your server.
if ((senderId).equals(from)) {
// Process message and then post a notification of the received message.
try {
JSONObject jsonObject = new JSONObject(data.getString(EXTRA_DATA));
String weather = jsonObject.getString(EXTRA_WEATHER);
String location = jsonObject.getString(EXTRA_LOCATION);
String weather = data.getString(EXTRA_WEATHER);
String location = data.getString(EXTRA_LOCATION);
String alert =
String.format(getString(R.string.gcm_weather_alert), weather, location);
sendNotification(alert);
} catch (JSONException e) {
// JSON parsing failed, so we just let this message go, since GCM is not one
// of our critical features.
}
}
Log.i(TAG, "Received: " + data.toString());
}
Expand Down Expand Up @@ -107,4 +100,4 @@ private void sendNotification(String message) {
mBuilder.setContentIntent(contentIntent);
mNotificationManager.notify(NOTIFICATION_ID, mBuilder.build());
}
}
}