Refactor to consistently init script and style in make_title_entry - #619
Merged
Conversation
…le and integrate them in `make_title_entry` when no `style` or `script` arg is passed to avoid the typical empty dict default arg trap and add consistency. Addressed a bunch of linting warnings from ruff.
jonasbardino
added this to the
Migration of scripts and services to new FHSesque locations milestone
jonasbardino
marked this pull request as ready for review
July 24, 2026 08:28
jonasbardino
deleted the
refactor/script-and-style-helper-init-and-avoid-empty-dict-default-trap-in-make-title-entry-args-plus-lint
branch
July 30, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move title style and script helper dicts from
outputtoinitmodule and integrate them inmake_title_entrywhen nostyleorscriptarg is passed to avoid the typical empty dict default arg trap and add consistency.Addressed a bunch of lint warnings from
ruff.Effectively replaces #615 which was otherwise gutted by latest changes to #612.