Auto-format code in tests/support for style compliance - #590
Open
jonasbardino wants to merge 1 commit into
Open
Conversation
`make format-python LINT_ENFORCE_DIRS=tests/support` run.
jonasbardino
changed the title
jonasbardino
added this to the
Migration of scripts and services to new FHSesque locations milestone
jonasbardino
marked this pull request as ready for review
July 10, 2026 12:53
Martin-Rehr
reviewed
Jul 28, 2026
| from tests.support.fixturesupp import _PreparedFixture | ||
| from tests.support.suppconst import MIG_BASE, TEST_BASE, \ | ||
| TEST_DATA_DIR, TEST_OUTPUT_DIR, ENVHELP_OUTPUT_DIR | ||
| from tests.support.suppconst import ( |
Contributor
There was a problem hiding this comment.
Didn't we agree on vertical hanging indent imports ?
Martin-Rehr
reviewed
Jul 28, 2026
| # failsafe path checking that supplied paths are rooted within valid paths | ||
| is_tmp_path_within_safe_dir = False | ||
| for start in (ENVHELP_OUTPUT_DIR): | ||
| for start in ENVHELP_OUTPUT_DIR: |
Contributor
There was a problem hiding this comment.
This will iterate over every char in ENVHELP_OUTPUT_DIR rather than the dir:
>>> ENVHELP_OUTPUT_DIR = "path1/path2/path3"
>>> for start in ENVHELP_OUTPUT_DIR:
... print(start)
...
p
a
t
h
1
/
p
a
t
h
2
/
p
a
t
h
3
I'll suggest the change:
- for start in (ENVHELP_OUTPUT_DIR):
+ for start in (ENVHELP_OUTPUT_DIR,):
Martin-Rehr
reviewed
Jul 28, 2026
|
|
||
| def close(self, *ars, **kwargs): | ||
| """"Simply ignore""" | ||
| """ "Simply ignore""" |
Martin-Rehr
approved these changes
Jul 28, 2026
Martin-Rehr
left a comment
Martin-Rehr
left a comment
Contributor
There was a problem hiding this comment.
Approved when comments are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply applied formatting rules to
tests/support/code with amake format-python LINT_ENFORCE_DIRS=tests/supportrun.
Should be followed by same to
tests/test*,mig/liband all proper files inbinandsbinfolders.