Skip to content

ubus: ignore a channel request after the channel was lost - #512

Merged
jow- merged 1 commit into
ucode-lang:masterfrom
blogic:pending-281026
Oct 28, 2026
Merged

jow- merged 1 commit into
ucode-lang:masterfrom
blogic:pending-281026

Conversation

@blogic

@blogic blogic commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

When the peer of a channel sends a request and then dies while this side waits in a synchronous request, ubus_complete_request() first runs the connection_lost callback, which releases the channel resource, and then delivers the request that was still buffered. uc_ubus_channel_req_cb() read the callback slot of the released resource and crashed.

Return UBUS_STATUS_CONNECTION_FAILED for such a request.

When the peer of a channel sends a request and then dies while this side
waits in a synchronous request, ubus_complete_request() first runs the
connection_lost callback, which releases the channel resource, and then
delivers the request that was still buffered. uc_ubus_channel_req_cb()
read the callback slot of the released resource and crashed.

Return UBUS_STATUS_CONNECTION_FAILED for such a request.

Signed-off-by: John Crispin <john@phrozen.org>
@jow-
jow- merged commit d6fec08 into ucode-lang:master Oct 28, 2026
2 checks passed
@jow-

jow- commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants