Add support for user-defined settings in Xcode build settings - #482
Open
manas-kulkarni wants to merge 3 commits into
Open
Add support for user-defined settings in Xcode build settings#482manas-kulkarni wants to merge 3 commits into
manas-kulkarni wants to merge 3 commits into
Conversation
jspelletier
reviewed
Aug 21, 2026
| /// User defined settings in Xcode build settings | ||
| /// Array of string user defined settings in Xcode build settings { "CUSTOM_SETTING = XYZ", "CUSTOM_SETTING_1 = ABC" } | ||
| /// </summary> | ||
| public class UserDefinedSettings : Strings |
Collaborator
There was a problem hiding this comment.
That should be named CustomBuildSettings since you are putting this into the BuildSettings section
jspelletier
reviewed
Aug 21, 2026
| options["LdRunPaths"] = ldRunPaths.Count > 0 ? XCodeUtil.XCodeFormatList(ldRunPaths, 4) : FileGeneratorUtilities.RemoveLineTag; | ||
|
|
||
| Strings userDefinedSettings = Options.GetStrings<Options.XCode.Compiler.UserDefinedSettings>(conf); | ||
| options["UserDefinedSettings"] = userDefinedSettings.Count > 0 ? string.Join($";{Environment.NewLine}", userDefinedSettings) : FileGeneratorUtilities.RemoveLineTag; |
Collaborator
There was a problem hiding this comment.
Rename to CustomBuildSettings
Collaborator
|
please modify one of the existing xcode samples to add a custom build setting. we need to insure this works for a real compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481