fix: use maxDragDistance instead of release distance to prevent releasing close to origin entering sticky-mode#42
Closed
blakkd wants to merge 1 commit into
Closed
Conversation
…far-drag returning to origin entering sticky mode Before: handleMouseUp checked distance from press origin to release position, so releasing near origin after dragging far was treated as a click (sticky scroll continued). After: maxDragDistance tracks the furthest distance traveled from origin during the session. Release now stops scroll if the cursor ever moves beyond dragThreshold, regardless of where it is released.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleMouseUponly checked release position against press origin. Now usesmaxDragDistancewhich tracks the furthest distance traveled during the middle-click/ctrl-click holding, so returning to origin before releasing is correctly recognized as a hold-scroll instead of a tap-scroll.