refactor: replace scrollOnLinks with drag-to-activate threshold#35
Open
ubermanu wants to merge 2 commits into
Open
refactor: replace scrollOnLinks with drag-to-activate threshold#35ubermanu wants to merge 2 commits into
ubermanu wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4c3603e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ubermanu
force-pushed
the
feat/drag-to-activate
branch
from
9fb5bdf to
786af02
Compare
After start() is called when the drag threshold is crossed, handleMouseMove is now invoked with the triggering event so dirX/dirY are seeded from the drag delta. Without this, the animation loop ran with zero velocity. Update e2e tests to use the new drag-to-activate pattern instead of the old press-and-release sticky-scroll flow.
Owner
Author
|
@jaminthorns @blakkd can you guys check if this branch is working properly for you? i've tested it on chrome/firefox and looks fine |
|
I just loaded the built extension from this branch, and it seems to remove the click-to-scroll functionality. Having drag-to-scroll be the default over links makes sense to me, but removing click-to-scroll completely seems like a regression. |
Contributor
|
I just tested and observed the same as @jaminthorns:
That said, I just noticed on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the need for scrollOnLinks completely
Closes #34