Repository navigation
Use the given estimators in get_synthetic_preds_holdout - #1067
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The function accepts an estimators dict and documents it, but the body never reads it and always builds the same eight S/T/X/R learners over LinearRegression and XGBRegressor, so a caller who passes their own estimator gets those defaults back instead. get_synthetic_preds already uses the argument, so mirror its if-estimators branch here, fitting on the training split and predicting on both splits. The existing test cannot catch this, because the two names it passes are names the hardcoded loop produces anyway. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_synthetic_preds_holdoutaccepts anestimatorsdict and documents it, but the body never reads it. It always builds the same eight S/T/X/R learners over LinearRegression and XGBRegressor, so a caller who passes an estimator gets those back instead, with no error.get_synthetic_predsalready uses the argument, and this brings the holdout version in line with it.The existing test passes
"S Learner (LR)"and"T Learner (XGB)", which are names the hardcoded loop produces anyway, so it passes either way. The new test uses a name the defaults cannot produce, and it fails on master. Calls that pass no estimators,get_synthetic_summary_holdoutincluded, are unaffected.