Repository navigation
Conversation
fillna(NAN_INT) raises TypeError on a pandas category column, since NAN_INT is not one of its categories. Cast category columns to object before filling. Add tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
LabelEncoderandOneHotEncoderincausalml/features.pyfill missing values withx.fillna(NAN_INT). On a pandascategorycolumn that raises:So both encoders crash on a category column with any missing value, while the same data as a plain string column works. This happens in
fit,transformandfit_transform.The fix adds a small helper that casts a category column to
objectbefore the fill, and uses it at the three places that callfillna(NAN_INT). Output for a category column now matches the output for the same values as strings.Types of changes
Checklist
Further comments
New parametrized test in
tests/test_features.pyfor both encoders: a category column with NaN encodes the same as the string column, throughfit_transformand throughfitthentransform. It fails on master and passes with the change.black --checkpasses.I used Claude to help find and fix this, and reviewed and tested the change myself.