Open
Conversation
Run modernize over the repository to update old Go idioms.
Changes include:
for i := 0; i < N; i++ -> for i := range N
interface{} -> any
for k, v := range x { y[k] = v } -> maps.Copy(y, x)
HasPrefix+TrimPrefix -> CutPrefix
Change generated by running:
```
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
```
rabbbit
reviewed
Oct 5, 2025
| //go:generate mockgen -package empty_interface -destination mock.go -source input.go | ||
|
|
||
| type Empty interface{} // migrating interface{} -> any does not resolve to an interface type. | ||
| type Empty any // migrating interface{} -> any does not resolve to an interface type. |
There was a problem hiding this comment.
this comment (and one above) doesn't seme to hold anymore? But also I don't understand what this means?
r-hang
approved these changes
Oct 5, 2025
JacobOaks
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run modernize over the repository to update old Go idioms.
Changes include:
Change generated by running: