Repository navigation
Fully normalize template names in FilesystemLoader - #5044
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
Leading slashes, `.` and `..` segments, and the `@__main__` prefix load the same compiled template as the canonical name. But the `Source` kept them as passed, so the name of the template and `_self` depended on the spelling used to load it first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #4985, which normalized backslashes and repeated slashes. Leading slashes,
.and..segments and the@__main__prefix also load the same compiled template as the canonical name. Until now, the name of the template and_selfdepended on the spelling used to load it first...segments are now resolved before looking up the file, soa/../xloadsxeven whenais a symlink or doesn't exist.