Repository navigation
Conversation
`extractBlockComponentNoCRC` is a drop-in replacement for upstream's `extractBlockComponent` for the `BlockComponent` shapes the GSA actually serves (`GetHash`, `GetSlot`, `GetIsEBB`, `GetBlockSize`, `GetHeaderSize`, `GetRawBlock`, `GetRawHeader`, `GetNestedCtxt`, plus `GetPure` / `GetApply` composition). Chunks served by the GSA are already CRC-verified at download time in `RemoteStorage`, so re-checking on every per-block read in the serving path is pure overhead. Profiling showed CRC32 prominent in the hot path; the removal contributed to a synthetic-bench jump from ~7 MB/s to ~13 MB/s @ p=8. Removing the dependency on `extractBlockComponent` also lets us drop the `DecodeDisk blk (ByteString -> blk)` and `DecodeDiskDep (NestedCtxt Header) blk` constraints from a number of signatures in both files.
vreuter
requested changes
May 15, 2026
| ChunkNo -> | ||
| m (Iterator m blk b) | ||
| mkRawBlockIterator hasFS chunkInfo codecConfig checkIntegrity component applyFrom applyTo chunk = do | ||
| mkRawBlockIterator hasFS chunkInfo _codecConfig _checkIntegrity component applyFrom applyTo chunk = do |
Contributor
There was a problem hiding this comment.
Why keep these parameters?
Assorted tweaks to CRC-skipping feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
extractBlockComponentwith aextractBlockComponentNoCRC, a drop-in replacementthat skips CRC check. This roughly doubles the throughput of the GSA.