Dialog/Drawer: fix focus-restore scroll and dispose-while-open cleanup#42544
Open
mdo wants to merge 2 commits into
Open
Dialog/Drawer: fix focus-restore scroll and dispose-while-open cleanup#42544mdo wants to merge 2 commits into
mdo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small dialog/drawer fixes, one per commit:
{ preventScroll: true }, so the page no longer jumps to the trigger (or to the top whenscroll-padding-topis set). Fixes offcanvas scrolls back to trigger element on close #38070, [offcanvas] - triggers unexpected scroll to top when scroll-padding-top is set on html, body #41615, Restore focus to modal triggering element using { preventScroll: true } #35391.dispose()now closes the native<dialog>and removes thedialog-openbody class if the instance is torn down while still open (e.g. an SPA route change), instead of leavingoverflow: hiddenstuck on the body. Fixes modal.dispose() does not fully clean up body element mutations #35934, Offcanvas - dispose() not reseting scrollbars #39910.Unit tests added/updated for both; full suite passes.
🤖 Generated with Claude Code