fix: reject multiple statements in single-statement APIs - #2277
Open
zfaustk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2244.
Single-statement
Connection::executeandConnection::querycalls now rejectmultiple executable SQL statements before any statement is stepped. The
explicit
execute_batchAPI keeps its existing multi-statement behavior.The guard is applied to local connections and embedded-replica
RemoteConnection/RemoteStatementpaths. This prevents the first statementfrom partially mutating the database when a second statement is supplied.
Verification
cargo test -p libsql --test integration_tests --no-default-features --features core,stream -- --nocapture(30 passed, 1 ignored)cargo test -p libsql --test replication --no-default-features --features replication -- --nocapture(2 passed)cargo check -p libsql --no-default-features --features core,replication(passed)cargo check -p libsql --no-default-features --features core,sync(passed)cargo check -p libsql --no-default-features --features core,remote(passed)cargo fmt --all -- --check(passed)git diff --check(passed)The full all-feature workspace check was not completed locally because the
environment does not provide
cmake; hosted CI will provide the remainingmatrix.
AI assistance was used for implementation and review; the final diff and
verification results were checked against the repository source and tests.