Repository navigation
Fix Basic Auth validation for token-based authentication - #1580
Open
wang-chuanhui wants to merge 2 commits into
Open
wang-chuanhui wants to merge 2 commits into
wang-chuanhui wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Basic Auth validation logic to allow requests without a Basic Authorization header to proceed to the subsequent token-based authentication flow.
Problem
The existing code returns false when the Authorization header is missing or shorter than 7 characters, preventing requests from reaching the subsequent WebSocket authentication flow.
Changes
Only validate Basic Auth credentials when the Authorization header is at least 7 characters long.
Allow requests without a valid Basic Auth header to proceed to the subsequent authentication flow, where the authToken sent via WebSocket is validated.
Testing
Verified that requests with valid Basic Auth credentials are still checked against the configured credentials.
Verified that requests without a Basic Auth header can proceed to token-based authentication.