Conversation
- Fix create.test.ts: await ky.post and assert response (was a race condition) - Add 2 new create tests: incrementing thing_ids, empty string acceptance - Add delete.test.ts: remove by id, idempotent no-op, new id after delete - Add list.test.ts: empty list, full field validation, insertion order, CRUD sequence
- Collapse .get().json() chains when type annotation is multi-line
- Remove non-null assertion (noNonNullAssertion lint rule)
- Sort imports: { expect, test } before { getTestServer }
- Preserve ! assertions (noNonNullAssertion is off in biome config)
jhzAliyy
force-pushed
the
bounty/ky-test-coverage-jhzaliyy
branch
from
June 22, 2026 07:16
1e09922 to
942e939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #2
Summary
Fixes and expands test coverage for the ky HTTP client migration bounty (#2):
create.test.ts (rewritten)
ky.post()was not awaitedthing_idto response typedelete.test.ts (new, 3 tests)
list.test.ts (new, 4 tests)
All tests use ky throughout, follow existing getTestServer pattern.
Closes #2