feat: schematic placement tools and pin-to-pin trace routing - #238
Open
AM-Mehrabii wants to merge 21 commits into
Open
feat: schematic placement tools and pin-to-pin trace routing#238AM-Mehrabii wants to merge 21 commits into
AM-Mehrabii wants to merge 21 commits into
Conversation
Extend SchematicViewer with additional draw modes (global labels, power and ground ports, text notes, hierarchical sheets, passive placement) and a draw_trace mode that emits edit_schematic_wire_add with an auto Manhattan route between two schematic ports. Share port hit-testing between wire and trace, skip mouse capture on UI marked data-schematic-ignore-mouse-capture, and fix bus finish plus hierarchical sheet dialog input stability.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AM-Mehrabii
force-pushed
the
feat/wire-drawing-gnd-placement
branch
from
July 14, 2026 06:33
dffc4c0 to
fa7c5a0
Compare
pnpm/vite install from GitHub needs compiled output because dist is not produced during git dependency install without devDependencies.
AM-Mehrabii
force-pushed
the
feat/wire-drawing-gnd-placement
branch
from
July 14, 2026 06:33
fa7c5a0 to
26439fd
Compare
Resolve SchematicViewer conflicts: keep draw tools alongside sheet selector, net hover, css/className props, and rename internal sheet id to selectedSchematicSheetId so host activeSheetId stays for hier placement.
Cast simulation current-graph circuit-json fields for dts generation and refresh dist output for git-based installs.
Drop verbose inline notes and keep only prop docs and non-obvious behavior comments that match the rest of schematic-viewer.
Fix format-check CI by running biome format on schematic draw/placement sources added in this branch.
…ce reshape Keep components/ports out of blocked screen areas during drag, and let users grab traces to move the L-corner while endpoints stay pinned. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the native sch-trace-hitbox path (same target as net hover) instead of a misaligned HTML overlay, and apply in-progress orthogonal routes live while dragging. Co-authored-by: Cursor <cursoragent@cursor.com>
Block canvas pan on wire/port hits, drag ports via SVG hit-targets, and keep select-mode port overlays available from the host app. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve source_port_id vs schematic_port_id on pin groups, keep native pin styling in select, and prefer local hit-targets so drags are visible. Co-authored-by: Cursor <cursoragent@cursor.com>
Shift only pin-attached vertices instead of rewriting traces as port-to-port L-routes, and avoid double-transforming pins that already move with their component group. Co-authored-by: Cursor <cursoragent@cursor.com>
Disable independent pin drag; keep orthogonal wire follow on component move and allow segment reshape with endpoints pinned to elements. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds interactive schematic drawing/placement modes to
SchematicViewer, emitting typed manual edit events for host apps to persist.Draw modes & edit events
toolModedraw_wireedit_schematic_wire_adddraw_busedit_schematic_bus_adddraw_bus_entryedit_schematic_bus_entry_adddraw_no_connectedit_schematic_no_connect_adddraw_net_labeledit_schematic_net_label_adddraw_global_labeledit_schematic_global_label_adddraw_power_portedit_schematic_power_port_adddraw_ground_portedit_schematic_ground_port_adddraw_text_noteedit_schematic_text_note_adddraw_hier_sheetedit_schematic_hier_sheet_adddraw_componentedit_schematic_component_adddraw_traceedit_schematic_wire_add(auto Manhattan route)Behaviour highlights
computeTraceRouteschematicPortHitTest.ts) for wire + tracedata-schematic-ignore-mouse-capture(host toolbars/dialogs)API
toolModevalues and matchingon*Addedcallbacks onSchematicViewerlib/index.ts)Test plan
data-schematic-ignore-mouse-capture)