Skip to content

🧪 Add error testing for CdpConfig::host_isolated_localhost - #32

Open
undivisible wants to merge 1 commit into
mainfrom
jules-test-coverage-16820371949676347824
Open

🧪 Add error testing for CdpConfig::host_isolated_localhost#32
undivisible wants to merge 1 commit into
mainfrom
jules-test-coverage-16820371949676347824

Conversation

@undivisible

@undivisible undivisible commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This pull request addresses the testing gap for the CdpConfig::host_isolated_localhost function by passing invalid arguments to the function and asserting that they each return the CdpError::InvalidConfig error. The newly added host_isolated_localhost_rejects_invalid_config function validates various edge case states (port 0, empty strings, missing browser_process_id, etc).


PR created automatically by Jules for task 16820371949676347824 started by @undivisible


Note

Low Risk
Test-only change; no runtime or CDP connection behavior is modified.

Overview
Adds unit test host_isolated_localhost_rejects_invalid_config so CdpConfig::host_isolated_localhost is covered the same way other localhost builders are for validation failures.

Each case passes bad input (port 0, empty or invalid target_id, browser_process_id 0, or a stale process_generation) and expects CdpError::InvalidConfig, matching the shared localhost_with_isolation checks used by both shared-desktop and host-isolated configs.

Reviewed by Cursor Bugbot for commit d2d4e33. Configure here.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant