🧪 Add error testing for CdpConfig::host_isolated_localhost - #32
🧪 Add error testing for CdpConfig::host_isolated_localhost#32undivisible wants to merge 1 commit into
Conversation
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This pull request addresses the testing gap for the
CdpConfig::host_isolated_localhostfunction by passing invalid arguments to the function and asserting that they each return theCdpError::InvalidConfigerror. The newly addedhost_isolated_localhost_rejects_invalid_configfunction validates various edge case states (port0, empty strings, missingbrowser_process_id, etc).PR created automatically by Jules for task 16820371949676347824 started by @undivisible
Note
Low Risk
Test-only change; no runtime or CDP connection behavior is modified.
Overview
Adds unit test
host_isolated_localhost_rejects_invalid_configsoCdpConfig::host_isolated_localhostis covered the same way other localhost builders are for validation failures.Each case passes bad input (port 0, empty or invalid target_id, browser_process_id 0, or a stale process_generation) and expects
CdpError::InvalidConfig, matching the sharedlocalhost_with_isolationchecks used by both shared-desktop and host-isolated configs.Reviewed by Cursor Bugbot for commit d2d4e33. Configure here.