🧪 Test coverage for mask_secrets - #77
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Tick the box to add this pull request to the merge queue (same as
|
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
5fd811a to
64bb4df
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🎯 What: Adds unit tests for the
mask_secretsfunction insrc/config/mod.rs, ensuring edge cases like empty strings, arrays, non-string values, and nested structures are handled correctly without modification while still properly hiding valid strings.📊 Coverage: The new test
mask_secrets_covers_objects_arrays_and_skips_emptythoroughly coversserde_json::Value::Object,serde_json::Value::Array, and wildcard (_) branches.✨ Result: Improved test coverage and codebase reliability.
PR created automatically by Jules for task 24631230648366902 started by @undivisible
Note
Low Risk
Test-only change with no runtime or config behavior modifications.
Overview
Adds
mask_secrets_covers_objects_arrays_and_skips_empty, a unit test that exercisesmask_secretsbeyond the existing config-serialization check.The new test verifies that non-empty string values on secret-like keys (
api_key,token,password, including nested objects and array elements) are replaced with********, while empty secret strings, null, non-string values on secret keys, and ordinary fields are left unchanged.Reviewed by Cursor Bugbot for commit 10fd12b. Configure here.