src/tlb.c: restore original order of operation for atype assignment#31
Merged
trofi merged 1 commit intotrofi:masterfrom Apr 17, 2026
Conversation
After 3279e9d trying to boot a Linux kernel in (b)ski's system mode hang early. As `&` takes precedence over `|` the assigned value of atypem is different after 3279e9d than the assigned value of atype was before that commit. Fixes: 3279e9d ("src/tlb.c: fix `Accesstype` vs `Accesstypemask` confsion") Reported-by: Willow <prometrium.dev@proton.me> Signed-off-by: Johnny Mnemonic <jm@machine-hall.org>
trofi
approved these changes
Apr 17, 2026
Owner
|
Apologies for the breakage. Pulled as is. Thank you! |
Contributor
Author
Really, no issue. I looked at 3279e9d for a while and really wondered where the difference is. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 3279e9d trying to boot a Linux kernel in (b)ski's system mode hang early.
As
&takes precedence over|the assigned value ofatypemis different after 3279e9d than the assigned value ofatypewas before that commit.Fixes #30